From: Kavyasree Kotagiri <redacted>
This patch introduces Microchip LAN966X ARMv7 based SoC family
of multiport gigabit AVB/TSN-capable ethernet switches.
It supports two SKUs: 4-port LAN9662 with multiprotocol
processing support and 8-port LAN9668 switch.
LAN966X includes copper and serial ethernet interfaces,
peripheral interfaces such as PCIe, USB, TWI, SPI, UART, QSPI,
SD/eMMC, Parallel Interface (PI) as well as synchronization
and trigger inputs/outputs.
Signed-off-by: Kavya Sree Kotagiri <redacted>
---
v1 -> v2:
- Removed lan966x_dt_device_init().
System boots fine without this function.
arch/arm/mach-at91/Kconfig | 13 +++++++++++++
arch/arm/mach-at91/Makefile | 1 +
arch/arm/mach-at91/lan966x.c | 25 +++++++++++++++++++++++++
3 files changed, 39 insertions(+)
create mode 100644 arch/arm/mach-at91/lan966x.c
From: Nicolas Ferre <nicolas.ferre@microchip.com> Date: 2021-09-17 13:41:09
On 31/08/2021 at 12:21, kavyasree.kotagiri@microchip.com wrote:
From: Kavyasree Kotagiri <redacted>
This patch introduces Microchip LAN966X ARMv7 based SoC family
of multiport gigabit AVB/TSN-capable ethernet switches.
It supports two SKUs: 4-port LAN9662 with multiprotocol
processing support and 8-port LAN9668 switch.
LAN966X includes copper and serial ethernet interfaces,
peripheral interfaces such as PCIe, USB, TWI, SPI, UART, QSPI,
SD/eMMC, Parallel Interface (PI) as well as synchronization
and trigger inputs/outputs.
Signed-off-by: Kavya Sree Kotagiri <redacted>
Your name fixed with your permission and as Rob suggested in a previous
series.
---
v1 -> v2:
- Removed lan966x_dt_device_init().
System boots fine without this function.
arch/arm/mach-at91/Kconfig | 13 +++++++++++++
arch/arm/mach-at91/Makefile | 1 +
Kconfig and Makefile files updated to avoid merge conflict with SAMA7G5
that was integrated in 5.15-rc1.
This compatibility string will need to be documented in
Documentation/arm/microchip.rst
and
Documentation/devicetree/bindings/arm/atmel-at91.yaml (or a similar
file, as you wish).
You'll add it to your DT patches.
All the rest looks good to me: no need to resend. It's queued in
at91-soc branch targeting 5.16.
You'll see it appearing in linux-next in the next few days.
Best regards,
Nicolas
--
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hello,
I wanted to reply earlier but I still have a few comments...
On 17/09/2021 15:41:01+0200, Nicolas Ferre wrote:
On 31/08/2021 at 12:21, kavyasree.kotagiri@microchip.com wrote:
quoted
From: Kavyasree Kotagiri <redacted>
This patch introduces Microchip LAN966X ARMv7 based SoC family
of multiport gigabit AVB/TSN-capable ethernet switches.
It supports two SKUs: 4-port LAN9662 with multiprotocol
processing support and 8-port LAN9668 switch.
LAN966X includes copper and serial ethernet interfaces,
peripheral interfaces such as PCIe, USB, TWI, SPI, UART, QSPI,
SD/eMMC, Parallel Interface (PI) as well as synchronization
and trigger inputs/outputs.
Signed-off-by: Kavya Sree Kotagiri <redacted>
Your name fixed with your permission and as Rob suggested in a previous
series.
quoted
---
v1 -> v2:
- Removed lan966x_dt_device_init().
System boots fine without this function.
arch/arm/mach-at91/Kconfig | 13 +++++++++++++
arch/arm/mach-at91/Makefile | 1 +
Kconfig and Makefile files updated to avoid merge conflict with SAMA7G5 that
was integrated in 5.15-rc1.
I don't think SOC_LAN966X is a good name or said differently as it is
not part specific, I don't get why this isn't merged with SOC_LAN966. I
would have one or the other.
This compatibility string will need to be documented in
Documentation/arm/microchip.rst
and
Documentation/devicetree/bindings/arm/atmel-at91.yaml (or a similar file, as
you wish).
You'll add it to your DT patches.
Yes and you'll have to document lan9662 and lan9668. Really, wildcards
in the compatible strings are usually not a good idea.
All the rest looks good to me: no need to resend. It's queued in at91-soc
branch targeting 5.16.
You'll see it appearing in linux-next in the next few days.
Well, I'm still wondering one thing, is arch/arm/mach-at91/lan966x.c
necessary at all to boot the platform?
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
-----Original Message-----
From: Alexandre Belloni [mailto:alexandre.belloni@bootlin.com]
Sent: Friday, September 17, 2021 8:03 PM
To: Nicolas Ferre - M43238 <Nicolas.Ferre@microchip.com>
Cc: Kavyasree Kotagiri - I30978 <redacted>; Ludovic
Desroches - M43218 [off-list ref];
linux@armlinux.org.uk; linux-arm-kernel@lists.infradead.org; linux-
kernel@vger.kernel.org; Manohar Puri - I30488
[off-list ref]; Madhuri Sripada - I34878
[off-list ref]
Subject: Re: [PATCH v2] ARM: at91: add basic support for new SoC lan966x
EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe
Hello,
I wanted to reply earlier but I still have a few comments...
On 17/09/2021 15:41:01+0200, Nicolas Ferre wrote:
quoted
On 31/08/2021 at 12:21, kavyasree.kotagiri@microchip.com wrote:
quoted
From: Kavyasree Kotagiri <redacted>
This patch introduces Microchip LAN966X ARMv7 based SoC family
of multiport gigabit AVB/TSN-capable ethernet switches.
It supports two SKUs: 4-port LAN9662 with multiprotocol
processing support and 8-port LAN9668 switch.
LAN966X includes copper and serial ethernet interfaces,
peripheral interfaces such as PCIe, USB, TWI, SPI, UART, QSPI,
SD/eMMC, Parallel Interface (PI) as well as synchronization
and trigger inputs/outputs.
Signed-off-by: Kavya Sree Kotagiri <redacted>
Your name fixed with your permission and as Rob suggested in a previous
series.
quoted
---
v1 -> v2:
- Removed lan966x_dt_device_init().
System boots fine without this function.
arch/arm/mach-at91/Kconfig | 13 +++++++++++++
arch/arm/mach-at91/Makefile | 1 +
Kconfig and Makefile files updated to avoid merge conflict with SAMA7G5
I don't think SOC_LAN966X is a good name or said differently as it is
not part specific, I don't get why this isn't merged with SOC_LAN966. I
would have one or the other.
I am using two different names to represent LAN966 as a new SoC family and
LAN966X as its SKU's - LAN9662 and LAN9668
This compatibility string will need to be documented in
Documentation/arm/microchip.rst
and
Documentation/devicetree/bindings/arm/atmel-at91.yaml (or a similar file,
as
quoted
you wish).
You'll add it to your DT patches.
Yes and you'll have to document lan9662 and lan9668. Really, wildcards
in the compatible strings are usually not a good idea.
All the rest looks good to me: no need to resend. It's queued in at91-soc
branch targeting 5.16.
You'll see it appearing in linux-next in the next few days.
Well, I'm still wondering one thing, is arch/arm/mach-at91/lan966x.c
necessary at all to boot the platform?
Yes, it is needed as it introduces new compatible string for new SoC LAN966X.
Could you please let me know if there is a different way to do this?
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com