[PATCH v3] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()

Subsystems: networking drivers, stmmac ethernet driver, the rest

STALE1843d

2 messages, 2 authors, 2021-08-31 · open the first message on its own page

[PATCH v3] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()

From: zhaoxiao <hidden>
Date: 2021-08-31 01:25:44

Change the pr_info to dev_err.

Signed-off-by: zhaoxiao <redacted>
---
v3:Remove the redundant blank line.
 drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index 4c9a37dd0d3f..f03f25d9adb0 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -54,14 +54,13 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
 	bool mdio = false;
 
 	np = dev_of_node(&pdev->dev);
-
 	if (!np) {
-		pr_info("dwmac_loongson_pci: No OF node\n");
+		dev_err(&pdev->dev, "dwmac_loongson_pci: No OF node\n");
 		return -ENODEV;
 	}
 
 	if (!of_device_is_compatible(np, "loongson, pci-gmac")) {
-		pr_info("dwmac_loongson_pci: Incompatible OF node\n");
+		dev_err(&pdev->dev, "dwmac_loongson_pci: Incompatible OF node\n");
 		return -ENODEV;
 	}
 
-- 
2.20.1




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-08-31 17:10:30

On Tue, 31 Aug 2021 09:25:23 +0800 zhaoxiao wrote:
Change the pr_info to dev_err.

Signed-off-by: zhaoxiao <redacted>
Your patches seem to not show up on the netdev mailing list.
They do make it to lkml and linux-arm tho, strangely.

Are you seeing any errors when sending them?

Please repost this one and CC warthog9@kernel.org - let's see 
if it gets thru..

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help