From: Matthew Hagan <hidden> Date: 2021-08-28 11:27:43
This board was added to
Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml. This patch
corrects bcm958623hr.dts by adding the board name to the compatible.
Signed-off-by: Matthew Hagan <redacted>
---
arch/arm/boot/dts/bcm958623hr.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Matthew Hagan <hidden> Date: 2021-08-28 11:27:48
This fixes the following message by appending "-bus" to mpcore node name:
mpcore@19000000: $nodename:0: 'mpcore@19000000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
Secondly this fixes the mmc node name. Leave the label name as is.
sdhci@21000: $nodename:0: 'sdhci@21000' does not match '^mmc(@.*)?$'
Signed-off-by: Matthew Hagan <redacted>
---
arch/arm/boot/dts/bcm-nsp.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Matthew Hagan <hidden> Date: 2021-08-28 11:27:50
This patch fixes the following message by adding "mdio-mux" compatible:
compatible: ['mdio-mux-mmioreg'] is too short
Signed-off-by: Matthew Hagan <redacted>
---
arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
From: Matthew Hagan <hidden> Date: 2021-08-28 11:27:52
This fixes the following issue by renaming the node appropriately:
at24@50: $nodename:0: 'at24@50' does not match '^eeprom@[0-9a-f]{1,2}$'
Signed-off-by: Matthew Hagan <redacted>
---
arch/arm/boot/dts/bcm958625-meraki-mx6x-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Matthew Hagan <hidden> Date: 2021-08-28 11:27:56
Firstly this fixes the following message:
mdio-mii-mux: $nodename:0: 'mdio-mii-mux' does not match '^mdio-mux[\\-@]?'
Secondly, move the mdio-mux to within the axi node and add the unit
address. This requires exposing the axi node via a label in bcm-nsp.dtsi.
This fixes the following warning:
Warning (unit_address_vs_reg): /mdio-mii-mux: node has a reg or ranges property, but no unit name
Signed-off-by: Matthew Hagan <redacted>
---
arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi | 6 ++++--
2 files changed, 5 insertions(+), 3 deletions(-)
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-08-28 17:07:19
On Sat, Aug 28, 2021 at 11:27:01AM +0000, Matthew Hagan wrote:
This patch fixes the following message by adding "mdio-mux" compatible:
compatible: ['mdio-mux-mmioreg'] is too short
Err, what? This sounds like a workaround for a tool problem, not a
real fix.
What is actually wrong with:
compatible = "mdio-mux-mmioreg";
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Matthew Hagan <hidden> Date: 2021-08-28 21:52:37
On 28/08/2021 18:07, Andrew Lunn wrote:
On Sat, Aug 28, 2021 at 11:27:01AM +0000, Matthew Hagan wrote:
quoted
This patch fixes the following message by adding "mdio-mux" compatible:
compatible: ['mdio-mux-mmioreg'] is too short
Err, what? This sounds like a workaround for a tool problem, not a
real fix.
What is actually wrong with:
compatible = "mdio-mux-mmioreg";
Yes this does work fine either with or without "mdio-mux". The changes
have been made to correspond with those submitted by Rafal Milecki for
the BCM5301X platform[1] and to conform with
Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml
which does state both as required items (and hence not a tool problem).
[1] https://lore.kernel.org/linux-arm-kernel/20210822191256.3715003-1-f.fainelli@gmail.com/T/
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-08-28 22:14:26
On Sat, Aug 28, 2021 at 10:52:30PM +0100, Matthew Hagan wrote:
On 28/08/2021 18:07, Andrew Lunn wrote:
quoted
On Sat, Aug 28, 2021 at 11:27:01AM +0000, Matthew Hagan wrote:
quoted
This patch fixes the following message by adding "mdio-mux" compatible:
compatible: ['mdio-mux-mmioreg'] is too short
Err, what? This sounds like a workaround for a tool problem, not a
real fix.
What is actually wrong with:
compatible = "mdio-mux-mmioreg";
Yes this does work fine either with or without "mdio-mux". The changes
have been made to correspond with those submitted by Rafal Milecki for
the BCM5301X platform[1] and to conform with
Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml
which does state both as required items (and hence not a tool problem).
Hi Matthew
It would be good to expand the commit message a bit, since the error
'is too short' is particularly uninformative, and leads to questions
like this if not explained.
It would also good to get the tool improved, but that is out of scope
for this patch.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-09-16 12:52:32
On Sat, Aug 28, 2021 at 11:27:01AM +0000, Matthew Hagan wrote:
This patch fixes the following message by adding "mdio-mux" compatible:
compatible: ['mdio-mux-mmioreg'] is too short
Signed-off-by: Matthew Hagan <redacted>