[PATCH][PULL/direct] ARM: s3c: delete unneed local variable "delay"

Subsystems: arm port, arm/samsung s3c, s5p and exynos arm architectures, the rest

STALE1826d

3 messages, 3 authors, 2021-08-19 · open the first message on its own page

[PATCH][PULL/direct] ARM: s3c: delete unneed local variable "delay"

From: Krzysztof Kozlowski <hidden>
Date: 2021-08-18 20:44:43

From: Jason Wang <redacted>

"delay" variable on line 79 can be deleted by returning "0" on line 88.

Signed-off-by: Jason Wang <redacted>
Link: https://lore.kernel.org/r/20210624055627.22295-1-wangborong@cdjrlc.com
Signed-off-by: Krzysztof Kozlowski <redacted>
---

Hi Arnd and Olof,

I have just one patch for Samsung ARM mach/soc, so sending this
directly.

Best regards,
Krzysztof


 arch/arm/mach-s3c/mach-gta02.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-s3c/mach-gta02.c b/arch/arm/mach-s3c/mach-gta02.c
index aec8b451c016..418939ce0fc3 100644
--- a/arch/arm/mach-s3c/mach-gta02.c
+++ b/arch/arm/mach-s3c/mach-gta02.c
@@ -79,13 +79,12 @@ static struct pcf50633 *gta02_pcf;
 
 static long gta02_panic_blink(int state)
 {
-	long delay = 0;
 	char led;
 
 	led = (state) ? 1 : 0;
 	gpio_direction_output(GTA02_GPIO_AUX_LED, led);
 
-	return delay;
+	return 0;
 }
 
 
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH][PULL/direct] ARM: s3c: delete unneed local variable "delay"

From: Arnd Bergmann <arnd@kernel.org>
Date: 2021-08-19 15:47:18

From: Arnd Bergmann <arnd@arndb.de>

On Wed, 18 Aug 2021 22:44:22 +0200, Krzysztof Kozlowski wrote:
"delay" variable on line 79 can be deleted by returning "0" on line 88.
Applied to for-next, thanks!

[1/1] ARM: s3c: delete unneed local variable "delay"
      commit: 319a1b58f6c7432345f13383b26c8c10e7eb1dda

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH][PULL/direct] ARM: s3c: delete unneed local variable "delay"

From: Arnd Bergmann <arnd@arndb.de>
Date: 2021-08-19 21:41:18

On Thu, Aug 19, 2021 at 5:44 PM Arnd Bergmann [off-list ref] wrote:
From: Arnd Bergmann <arnd@arndb.de>

On Wed, 18 Aug 2021 22:44:22 +0200, Krzysztof Kozlowski wrote:
quoted
"delay" variable on line 79 can be deleted by returning "0" on line 88.
Applied to for-next, thanks!

[1/1] ARM: s3c: delete unneed local variable "delay"
      commit: 319a1b58f6c7432345f13383b26c8c10e7eb1dda
I had accidentally added this to the arm/fixes branch at first, but corrected
that now and applied it to arm/soc instead, as you intended.

          Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help