[PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in

Subsystems: arm port, the rest

STALE1847d

4 messages, 3 authors, 2021-07-16 · open the first message on its own page

[PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in

From: Stefan Wahren <hidden>
Date: 2021-07-10 11:11:54

The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
been a "regression source" a lot of times. The last case is breakage of
USB mass storage boot has been commit e590474768f1 ("driver core: Set
fw_devlink=on by default") for multi_v7_defconfig. As long as
NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
endlessly and prevent booting from USB mass storage device. So make
the driver built-in as in bcm2835_defconfig and arm64/defconfig.

Reported-by: Ojaswin Mujoo <redacted>
Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
Signed-off-by: Stefan Wahren <redacted>
---
 arch/arm/configs/multi_v7_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 52a0400..d9abaae 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -821,7 +821,7 @@ CONFIG_USB_ISP1760=y
 CONFIG_USB_HSIC_USB3503=y
 CONFIG_AB8500_USB=y
 CONFIG_KEYSTONE_USB_PHY=m
-CONFIG_NOP_USB_XCEIV=m
+CONFIG_NOP_USB_XCEIV=y
 CONFIG_AM335X_PHY_USB=m
 CONFIG_TWL6030_USB=m
 CONFIG_USB_GPIO_VBUS=y
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-07-11 21:30:10


On 7/10/2021 4:04 AM, Stefan Wahren wrote:
The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
been a "regression source" a lot of times. The last case is breakage of
USB mass storage boot has been commit e590474768f1 ("driver core: Set
fw_devlink=on by default") for multi_v7_defconfig. As long as
NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
endlessly and prevent booting from USB mass storage device. So make
the driver built-in as in bcm2835_defconfig and arm64/defconfig.
Should not that be fixed somehow?
quoted hunk
Reported-by: Ojaswin Mujoo <redacted>
Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
Signed-off-by: Stefan Wahren <redacted>
---
  arch/arm/configs/multi_v7_defconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 52a0400..d9abaae 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -821,7 +821,7 @@ CONFIG_USB_ISP1760=y
  CONFIG_USB_HSIC_USB3503=y
  CONFIG_AB8500_USB=y
  CONFIG_KEYSTONE_USB_PHY=m
-CONFIG_NOP_USB_XCEIV=m
+CONFIG_NOP_USB_XCEIV=y
  CONFIG_AM335X_PHY_USB=m
  CONFIG_TWL6030_USB=m
  CONFIG_USB_GPIO_VBUS=y
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in

From: Stefan Wahren <hidden>
Date: 2021-07-12 05:06:07

Hi Florian,

Am 11.07.21 um 23:27 schrieb Florian Fainelli:

On 7/10/2021 4:04 AM, Stefan Wahren wrote:
quoted
The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
been a "regression source" a lot of times. The last case is breakage of
USB mass storage boot has been commit e590474768f1 ("driver core: Set
fw_devlink=on by default") for multi_v7_defconfig. As long as
NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
endlessly and prevent booting from USB mass storage device. So make
the driver built-in as in bcm2835_defconfig and arm64/defconfig.
Should not that be fixed somehow?
maybe that why send this bug report, but never get a feedback [1]

My spare time is too limited to fight multiple regressions on Raspberry
Pi, so i decided send at least this solution.

[1] - https://www.spinics.net/lists/arm-kernel/msg905208.html
quoted
Reported-by: Ojaswin Mujoo <redacted>
Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
Signed-off-by: Stefan Wahren <redacted>
---  

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in

From: Arnd Bergmann <arnd@kernel.org>
Date: 2021-07-16 21:31:45

From: Arnd Bergmann <arnd@arndb.de>

On Sat, 10 Jul 2021 13:04:55 +0200, Stefan Wahren wrote:
The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
been a "regression source" a lot of times. The last case is breakage of
USB mass storage boot has been commit e590474768f1 ("driver core: Set
fw_devlink=on by default") for multi_v7_defconfig. As long as
NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
endlessly and prevent booting from USB mass storage device. So make
the driver built-in as in bcm2835_defconfig and arm64/defconfig.
Applied to arm/fixes, thanks!

[1/1] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
      commit: ab37a7a890c1176144a4c66ff3d51ef2c20ed486

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help