PM support for SAMA7G5 has been submitted to mailing list before SAMA7G5
soc support thus the SAMA7G5 was not present in AT91 Kconfig file at
that moment. SoC support for SAMA7G5 hasn't added the proper PM flags to
Kconfig thus the link error bellow:
arch/arm/mach-at91/sama7.o: In function `sama7_dt_device_init':
sama7.c:(.init.text+0x18): undefined reference to `sama7_pm_init'
make: *** [Makefile:1176: vmlinux] Error 1
Add proper flags to AT91 Kconfig file to solve the issue.
Fixes: 5617a08dd9e1 ("ARM: at91: pm: add pm support for SAMA7G5")
Fixes: 18d694ecd91e ("ARM: at91: add new SoC sama7g5")
Signed-off-by: Claudiu Beznea <redacted>
---
arch/arm/mach-at91/Kconfig | 3 +++
1 file changed, 3 insertions(+)
Add register definitions for SAMA7G5's master clock. These would be
also used by architecture specific power saving code.
Fixes: 6cb0e54412a3 ("ARM: at91: pm: add support for MCK1..4 save/restore for ulp modes")
Signed-off-by: Claudiu Beznea <redacted>
---
Hi Stephen,
This is a part from patch at [1]. I keep it at minimum (only definitions)
for faster acceptance as the build is broken on arm multi_v7_defconfig
without it).
In next version of patch at [1] I will update it accordingly.
Thank you,
Claudiu Beznea
[1] https://lore.kernel.org/linux-clk/20210401122726.28528-5-claudiu.beznea@microchip.com/
include/linux/clk/at91_pmc.h | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
From: Nicolas Ferre <nicolas.ferre@microchip.com> Date: 2021-07-19 12:40:33
Hi Claudiu,
On 19/07/2021 at 10:03, Claudiu Beznea wrote:
quoted hunk
PM support for SAMA7G5 has been submitted to mailing list before SAMA7G5
soc support thus the SAMA7G5 was not present in AT91 Kconfig file at
that moment. SoC support for SAMA7G5 hasn't added the proper PM flags to
Kconfig thus the link error bellow:
arch/arm/mach-at91/sama7.o: In function `sama7_dt_device_init':
sama7.c:(.init.text+0x18): undefined reference to `sama7_pm_init'
make: *** [Makefile:1176: vmlinux] Error 1
Add proper flags to AT91 Kconfig file to solve the issue.
Fixes: 5617a08dd9e1 ("ARM: at91: pm: add pm support for SAMA7G5")
Fixes: 18d694ecd91e ("ARM: at91: add new SoC sama7g5")
Signed-off-by: Claudiu Beznea <redacted>
---
arch/arm/mach-at91/Kconfig | 3 +++
1 file changed, 3 insertions(+)
From: Nicolas Ferre <nicolas.ferre@microchip.com> Date: 2021-07-19 12:46:06
On 19/07/2021 at 10:03, Claudiu Beznea wrote:
Add register definitions for SAMA7G5's master clock. These would be
also used by architecture specific power saving code.
Fixes: 6cb0e54412a3 ("ARM: at91: pm: add support for MCK1..4 save/restore for ulp modes")
Signed-off-by: Claudiu Beznea <redacted>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Hi Stephen,
This is a part from patch at [1]. I keep it at minimum (only definitions)
for faster acceptance as the build is broken on arm multi_v7_defconfig
without it).
In next version of patch at [1] I will update it accordingly.
Stephen,
Before hearing from you I inserted this patch in our at91-soc branch
that is part of linux-next. With this at least the build don't break
anymore.
Tell me if you want to have an immutable branch that we could share with
it on top of 5.14-rc1 or if it's fine if we add the same patch in both
of our trees.
Best regards,
Nicolas
Hi Claudiu,
On 19/07/2021 at 10:03, Claudiu Beznea wrote:
quoted
PM support for SAMA7G5 has been submitted to mailing list before SAMA7G5
soc support thus the SAMA7G5 was not present in AT91 Kconfig file at
that moment. SoC support for SAMA7G5 hasn't added the proper PM flags to
Kconfig thus the link error bellow:
arch/arm/mach-at91/sama7.o: In function `sama7_dt_device_init':
sama7.c:(.init.text+0x18): undefined reference to `sama7_pm_init'
make: *** [Makefile:1176: vmlinux] Error 1
Add proper flags to AT91 Kconfig file to solve the issue.
Fixes: 5617a08dd9e1 ("ARM: at91: pm: add pm support for SAMA7G5")
Fixes: 18d694ecd91e ("ARM: at91: add new SoC sama7g5")
Signed-off-by: Claudiu Beznea <redacted>
---
arch/arm/mach-at91/Kconfig | 3 +++
1 file changed, 3 insertions(+)
From: Stephen Boyd <sboyd@kernel.org> Date: 2021-07-27 01:19:33
Quoting Nicolas Ferre (2021-07-19 05:46:00)
On 19/07/2021 at 10:03, Claudiu Beznea wrote:
quoted
Add register definitions for SAMA7G5's master clock. These would be
also used by architecture specific power saving code.
Fixes: 6cb0e54412a3 ("ARM: at91: pm: add support for MCK1..4 save/restore for ulp modes")
Signed-off-by: Claudiu Beznea <redacted>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
quoted
---
Hi Stephen,
This is a part from patch at [1]. I keep it at minimum (only definitions)
for faster acceptance as the build is broken on arm multi_v7_defconfig
without it).
In next version of patch at [1] I will update it accordingly.
Stephen,
Before hearing from you I inserted this patch in our at91-soc branch
that is part of linux-next. With this at least the build don't break
anymore.
I don't think I need the patches? I'll try to remember this patch if I
apply some patch that needs this in the future and probably just
duplicate the commit to make things simpler.
Tell me if you want to have an immutable branch that we could share with
it on top of 5.14-rc1 or if it's fine if we add the same patch in both
of our trees.