# Re: \[PATCH v2 1/1\] psi: stop relying on timer\_pending for poll\_work rescheduling

- From: Suren Baghdasaryan \<surenb@google.com\>
- Date: 2021-07-01 16:09:40 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2021/07/1430833
- Thread: https://ratatoskr.run/linux-arm-kernel/2021/06/1430272/t.md

```text
On Thu, Jul 1, 2021 at 1:59 AM Peter Zijlstra [ref] wrote:
>
> On Wed, Jun 30, 2021 at 01:51:51PM -0700, Suren Baghdasaryan wrote:
> > +     /* cmpxchg should be called even when !force to set poll_scheduled */
> > +     if (atomic_cmpxchg(&group->poll_scheduled, 0, 1) && !force)
> >               return;
>
> Why is that a cmpxchg() ?

We want to set poll_scheduled and proceed with rescheduling the timer
unless it's already scheduled, so cmpxchg helps us to make that
decision atomically. Or did I misunderstand your question?

>
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
```
