[v1,0/3] watchdog: mt8195: add wdt support

christine.zhu (3):
  dt-binding: mt8195: update mtk-wdt document
  dt-binding: mt8195: add toprgu reset-controller head file
  watchdog: mt8195: add wdt support

 .../devicetree/bindings/watchdog/mtk-wdt.txt  |  2 +-
 drivers/watchdog/mtk_wdt.c                    |  5 ++++
 include/dt-bindings/reset/mt8195-resets.h     | 29 +++++++++++++++++++
 3 files changed, 35 insertions(+), 1 deletion(-)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

From: "christine.zhu" <redacted>

update mtk-wdt document for MT8195 platform

Change-Id: Id18393e8deff2c3492e21c85e97a28e88bc9ca0f
Signed-off-by: christine.zhu <redacted>
---
 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
index e36ba60de829..64d812893dba 100644
--- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

@@ -13,7 +13,7 @@ Required properties:
 	"mediatek,mt8183-wdt": for MT8183
 	"mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
 	"mediatek,mt8192-wdt": for MT8192
-
+        "mediatek,mt8195-wdt": for MT8195
 - reg : Specifies base physical address and size of the registers.
 
 Optional properties:

-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

From: "christine.zhu" <redacted>

add toprgu reset-controller head file for MT8195 platform

Change-Id: Ib08da609e87d31ff0aa06b066f9797070931a693
Signed-off-by: christine.zhu <redacted>
---
 include/dt-bindings/reset/mt8195-resets.h | 29 +++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 include/dt-bindings/reset/mt8195-resets.h

diff --git a/include/dt-bindings/reset/mt8195-resets.h b/include/dt-bindings/reset/mt8195-resets.h
new file mode 100644
index 000000000000..620a594ee743
--- /dev/null
+++ b/include/dt-bindings/reset/mt8195-resets.h

@@ -0,0 +1,29 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2020 MediaTek Inc.
+ * Author: Crystal Guo <crystal.guo@mediatek.com>
+ */
+ 
+#ifndef _DT_BINDINGS_RESET_CONTROLLER_MT8195
+#define _DT_BINDINGS_RESET_CONTROLLER_MT8195
+
+#define MT8195_TOPRGU_CONN_MCU_SW_RST          0
+#define MT8195_TOPRGU_INFRA_GRST_SW_RST        1
+#define MT8195_TOPRGU_APU_SW_RST               2
+#define MT8195_TOPRGU_INFRA_AO_GRST_SW_RST     6
+#define MT8195_TOPRGU_MMSYS_SW_RST             7
+#define MT8195_TOPRGU_MFG_SW_RST               8
+#define MT8195_TOPRGU_VENC_SW_RST              9
+#define MT8195_TOPRGU_VDEC_SW_RST              10
+#define MT8195_TOPRGU_IMG_SW_RST               11
+#define MT8195_TOPRGU_APMIXEDSYS_SW_RST        13
+#define MT8195_TOPRGU_AUDIO_SW_RST             14
+#define MT8195_TOPRGU_CAMSYS_SW_RST            15
+#define MT8195_TOPRGU_EDPTX_SW_RST             16
+#define MT8195_TOPRGU_ADSPSYS_SW_RST           21
+#define MT8195_TOPRGU_DPTX_SW_RST              22
+#define MT8195_TOPRGU_SPMI_MST_SW_RST          23
+
+#define MT8195_TOPRGU_SW_RST_NUM               16
+
+#endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT8195 */

-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

From: "christine.zhu" <redacted>

add support for watchdog device found in MT8195 SoC

Change-Id: Ib2434cf2d47a2e14916056f08a4fc630569624ed
Signed-off-by: christine.zhu <redacted>
---
 drivers/watchdog/mtk_wdt.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
index 97ca993bd009..5e9e4db8d51a 100644
--- a/drivers/watchdog/mtk_wdt.c
+++ b/drivers/watchdog/mtk_wdt.c

@@ -12,6 +12,7 @@
 #include <dt-bindings/reset-controller/mt2712-resets.h>
 #include <dt-bindings/reset-controller/mt8183-resets.h>
 #include <dt-bindings/reset-controller/mt8192-resets.h>
+#include <dt-bindings/reset-controller/mt8195-resets.h>
 #include <linux/delay.h>
 #include <linux/err.h>
 #include <linux/init.h>

@@ -81,6 +82,10 @@ static const struct mtk_wdt_data mt8192_data = {
 	.toprgu_sw_rst_num = MT8192_TOPRGU_SW_RST_NUM,
 };
 
+static const struct mtk_wdt_data mt8195_data = {
+	.toprgu_sw_rst_num = MT8195_TOPRGU_SW_RST_NUM,
+};
+
 static int toprgu_reset_update(struct reset_controller_dev *rcdev,
 			       unsigned long id, bool assert)
 {

-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

On Sun, Jun 20, 2021 at 9:50 PM Christine Zhu
[off-list ref] wrote:

add support for watchdog device found in MT8195 SoC

Please write complete sentences.  For example, "Supports MT8195
watchdog device."

Change-Id: Ib2434cf2d47a2e14916056f08a4fc630569624ed

Remove the unneeded tag.

+static const struct mtk_wdt_data mt8195_data = {
+       .toprgu_sw_rst_num = MT8195_TOPRGU_SW_RST_NUM,
+};

Expect to see the of_device_id (i.e. mtk_wdt_dt_ids) has the newly
introduced compatible string and use the mt8195_data but failed to
find it.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

On Sun, Jun 20, 2021 at 9:50 PM Christine Zhu
[off-list ref] wrote:

christine.zhu (3):
  dt-binding: mt8195: update mtk-wdt document
  dt-binding: mt8195: add toprgu reset-controller head file
  watchdog: mt8195: add wdt support

Please provide some information in the cover letter to let people know
what the series fixes about.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

On Sun, Jun 20, 2021 at 9:50 PM Christine Zhu
[off-list ref] wrote:

update mtk-wdt document for MT8195 platform

Please write complete sentences.

Change-Id: Id18393e8deff2c3492e21c85e97a28e88bc9ca0f

Remove the unneeded tag.

The patch needs other proper prefixes.  For example, "dt-bindings:
mediatek: mt8195:".

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

On Sun, Jun 20, 2021 at 9:50 PM Christine Zhu
[off-list ref] wrote:

add toprgu reset-controller head file for MT8195 platform

Please write complete sentences.

Change-Id: Ib08da609e87d31ff0aa06b066f9797070931a693

Remove the unneeded tag.

+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2020 MediaTek Inc.

Maybe 2021?

The patch needs other proper prefixes.  For example, "dt-bindings:
reset: mt8195".

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel