[PATCH -next] dmaengine: sun4i: Use list_move_tail instead of list_del/list_add_tail

Subsystems: dma generic offload engine subsystem, the rest

STALE1885d LANDED

Landed in mainline as 2e5c09d19e63 on 2021-06-07.

3 messages, 3 authors, 2021-06-07 · open the first message on its own page

[PATCH -next] dmaengine: sun4i: Use list_move_tail instead of list_del/list_add_tail

From: Zou Wei <hidden>
Date: 2021-06-07 03:02:03

Using list_move_tail() instead of list_del() + list_add_tail().

Reported-by: Hulk Robot <redacted>
Signed-off-by: Zou Wei <redacted>
---
 drivers/dma/sun4i-dma.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c
index e8b6633..93f1645 100644
--- a/drivers/dma/sun4i-dma.c
+++ b/drivers/dma/sun4i-dma.c
@@ -1042,9 +1042,8 @@ static irqreturn_t sun4i_dma_interrupt(int irq, void *dev_id)
 			 * Move the promise into the completed list now that
 			 * we're done with it
 			 */
-			list_del(&vchan->processing->list);
-			list_add_tail(&vchan->processing->list,
-				      &contract->completed_demands);
+			list_move_tail(&vchan->processing->list,
+				       &contract->completed_demands);
 
 			/*
 			 * Cyclic DMA transfers are special:
-- 
2.6.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH -next] dmaengine: sun4i: Use list_move_tail instead of list_del/list_add_tail

From: Maxime Ripard <hidden>
Date: 2021-06-07 08:41:50

On Mon, Jun 07, 2021 at 11:20:35AM +0800, Zou Wei wrote:
Using list_move_tail() instead of list_del() + list_add_tail().

Reported-by: Hulk Robot <redacted>
Signed-off-by: Zou Wei <redacted>
Acked-by: Maxime Ripard <redacted>

Thanks!
Maxime

Re: [PATCH -next] dmaengine: sun4i: Use list_move_tail instead of list_del/list_add_tail

From: Vinod Koul <vkoul@kernel.org>
Date: 2021-06-07 11:36:54

On 07-06-21, 11:20, Zou Wei wrote:
Using list_move_tail() instead of list_del() + list_add_tail().
Applied, thanks

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help