ti,pindir-d0-out-d1-in property is expected to be of type boolean.
Therefore, fix the property accordingly.
Signed-off-by: Aswath Govindraju <redacted>
---
arch/arm/boot/dts/am335x-cm-t335.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ti,pindir-d0-out-d1-in property is expected to be of type boolean.
Therefore, fix the property accordingly.
Signed-off-by: Aswath Govindraju <redacted>
---
arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
ti,pindir-d0-out-d1-in property is expected to be of type boolean.
Therefore, fix the property accordingly.
Signed-off-by: Aswath Govindraju <redacted>
---
arch/arm64/boot/dts/ti/k3-am642-evm.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -1,48 +0,0 @@-OMAP2+ McSPI device--Required properties:-- compatible :- - "ti,am654-mcspi" for AM654.- - "ti,omap2-mcspi" for OMAP2 & OMAP3.- - "ti,omap4-mcspi" for OMAP4+.-- ti,spi-num-cs : Number of chipselect supported by the instance.-- ti,hwmods: Name of the hwmod associated to the McSPI-- ti,pindir-d0-out-d1-in: Select the D0 pin as output and D1 as- input. The default is D0 as input and- D1 as output.--Optional properties:-- dmas: List of DMA specifiers with the controller specific format- as described in the generic DMA client binding. A tx and rx- specifier is required for each chip select.-- dma-names: List of DMA request names. These strings correspond- 1:1 with the DMA specifiers listed in dmas. The string naming- is to be "rxN" and "txN" for RX and TX requests,- respectively, where N equals the chip select number.--Examples:--[hwmod populated DMA resources]--mcspi1: mcspi@1 {- #address-cells = <1>;- #size-cells = <0>;- compatible = "ti,omap4-mcspi";- ti,hwmods = "mcspi1";- ti,spi-num-cs = <4>;-};--[generic DMA request binding]--mcspi1: mcspi@1 {- #address-cells = <1>;- #size-cells = <0>;- compatible = "ti,omap4-mcspi";- ti,hwmods = "mcspi1";- ti,spi-num-cs = <2>;- dmas = <&edma 42- &edma 43- &edma 44- &edma 45>;- dma-names = "tx0", "rx0", "tx1", "rx1";-};
@@ -0,0 +1,126 @@+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)+%YAML1.2+---+$id:http://devicetree.org/schemas/spi/omap-spi.yaml#+$schema:http://devicetree.org/meta-schemas/core.yaml#++title:SPI controller bindings for OMAP and K3 SoCs++maintainers:+-Mark Brown <broonie@kernel.org>++properties:+compatible:+oneOf:+-items:+-enum:+-ti,am654-mcspi+-ti,am4372-mcspi+-const:ti,omap4-mcspi+-items:+-enum:+-ti,omap2-mcspi+-ti,omap4-mcspi++reg:+maxItems:1++interrupts:+maxItems:1++clocks:+maxItems:1++'#address-cells':+const:1++'#size-cells':+const:0++power-domains:+maxItems:1++ti,spi-num-cs:+$ref:/schemas/types.yaml#/definitions/uint32+description:Number of chipselect supported by the instance.+minimum:1+maximum:4++ti,hwmods:+$ref:/schemas/types.yaml#/definitions/string+description:+Must be "mcspi<n>", n being the instance number (1-based).+This property is applicable only on legacy platforms mainly omap2/3+and ti81xx and should not be used on other platforms.+deprecated:true++ti,pindir-d0-out-d1-in:+description:+Select the D0 pin as output and D1 as input. The default is D0+as input and D1 as output.+type:boolean++dmas:+description:+List of DMA specifiers with the controller specific format as+described in the generic DMA client binding. A tx and rx+specifier is required for each chip select.+minItems:1+maxItems:8++dma-names:+description:+List of DMA request names. These strings correspond 1:1 with+the DMA sepecifiers listed in dmas. The string names is to be+"rxN"and "txN" for RX and TX requests, respectively. Where N+is the chip select number.+minItems:1+maxItems:8++patternProperties:+"@[0-9a-f]+$":+type:object+description:+Flash devices are defined as a sub-node of the spi controller++required:+-compatible+-reg+-interrupts++additionalProperties:false++if:+properties:+compatible:+oneOf:+-const:ti,omap2-mcspi+-const:ti,omap4-mcspi++then:+properties:+ti,hwmods:+items:+-pattern:"^mcspi([1-9])$"++else:+properties:+ti,hwmods:false++examples:+-|+#include <dt-bindings/interrupt-controller/irq.h>+#include <dt-bindings/interrupt-controller/arm-gic.h>+#include <dt-bindings/soc/ti,sci_pm_domain.h>++main_spi0:spi@2100000 {+compatible = "ti,am654-mcspi","ti,omap4-mcspi";+reg = <0x2100000 0x400>;+interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;+clocks = <&k3_clks 137 1>;+power-domains = <&k3_pds 137 TI_SCI_PD_EXCLUSIVE>;+#address-cells = <1>;+#size-cells = <0>;+dmas = <&main_udmap 0xc500>, <&main_udmap 0x4500>;+dma-names = "tx0", "rx0";+};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
ti,pindir-d0-out-d1-in property is expected to be of type boolean.
Therefore, fix the property accordingly.
Signed-off-by: Aswath Govindraju <redacted>
No need for Fixes?
Also please split up the patches per maintainer so that we are'nt
confused on who should pick what etc..
Hi Nishanth,
On 07/06/21 7:10 pm, Nishanth Menon wrote:
On 18:04-20210602, Aswath Govindraju wrote:
quoted
ti,pindir-d0-out-d1-in property is expected to be of type boolean.
Therefore, fix the property accordingly.
Signed-off-by: Aswath Govindraju <redacted>
No need for Fixes?
Functionality wise this is not a bug as the driver only checks for the
presence of the property. This is the reason why I did not include fixes.
Also please split up the patches per maintainer so that we are'nt
confused on who should pick what etc..
okay. Will be aware of this from next time.
Thanks,
Aswath
Hi Nishanth,
On 07/06/21 7:10 pm, Nishanth Menon wrote:
quoted
On 18:04-20210602, Aswath Govindraju wrote:
quoted
ti,pindir-d0-out-d1-in property is expected to be of type boolean.
Therefore, fix the property accordingly.
Signed-off-by: Aswath Govindraju <redacted>
No need for Fixes?
Functionality wise this is not a bug as the driver only checks for the
presence of the property. This is the reason why I did not include fixes.
Argument was based on device tree is considered independent of what or
what not a driver does.
quoted
Also please split up the patches per maintainer so that we are'nt
confused on who should pick what etc..
okay. Will be aware of this from next time.
Actually, I have dropped this off my list. I am assuming you'd want the
bindings to be merged after the dts cleanup is done.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel