[PATCH] drm/rockchip: defined struct rockchip_dp_dt_ids[] under CONFIG_OF

Subsystems: arm/rockchip soc support, drm drivers, drm drivers and misc gpu patches, drm drivers for rockchip, the rest

STALE1920d

3 messages, 2 authors, 2021-06-07 · open the first message on its own page

[PATCH] drm/rockchip: defined struct rockchip_dp_dt_ids[] under CONFIG_OF

From: Souptick Joarder <hidden>
Date: 2021-06-02 08:02:35 

Kernel test robot throws below warning when CONFIG_OF
is not set.
quoted
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:457:34:
warning: unused variable 'rockchip_dp_dt_ids' [-Wunused-const-variable]
   static const struct of_device_id rockchip_dp_dt_ids[] = {

Fixed it by defining rockchip_dp_dt_ids[] under CONFIG_OF.

Reported-by: kernel test robot <redacted>
Signed-off-by: Souptick Joarder <redacted>
---
 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index ade2327a10e2..9b79ebaeae97 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -454,12 +454,14 @@ static const struct rockchip_dp_chip_data rk3288_dp = {
 	.chip_type = RK3288_DP,
 };
 
+#ifdef CONFIG_OF
 static const struct of_device_id rockchip_dp_dt_ids[] = {
 	{.compatible = "rockchip,rk3288-dp", .data = &rk3288_dp },
 	{.compatible = "rockchip,rk3399-edp", .data = &rk3399_edp },
 	{}
 };
 MODULE_DEVICE_TABLE(of, rockchip_dp_dt_ids);
+#endif
 
 struct platform_driver rockchip_dp_driver = {
 	.probe = rockchip_dp_probe,
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] drm/rockchip: defined struct rockchip_dp_dt_ids[] under CONFIG_OF

From: Robin Murphy <robin.murphy@arm.com>
Date: 2021-06-02 10:07:16 

On 2021-06-02 09:02, Souptick Joarder wrote:
Kernel test robot throws below warning when CONFIG_OF
is not set.
quoted
quoted
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:457:34:
warning: unused variable 'rockchip_dp_dt_ids' [-Wunused-const-variable]
    static const struct of_device_id rockchip_dp_dt_ids[] = {

Fixed it by defining rockchip_dp_dt_ids[] under CONFIG_OF.
I think the __maybe_unused annotation is generally preferred over 
#ifdefs these days. However, since these drivers only work with 
devicetree anyway, it probably makes more sense to just remove the 
of_match_ptr() uses which lead to these warnings in the first place.

Robin.
quoted hunk
Reported-by: kernel test robot <redacted>
Signed-off-by: Souptick Joarder <redacted>
---
  drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index ade2327a10e2..9b79ebaeae97 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -454,12 +454,14 @@ static const struct rockchip_dp_chip_data rk3288_dp = {
  	.chip_type = RK3288_DP,
  };
  
+#ifdef CONFIG_OF
  static const struct of_device_id rockchip_dp_dt_ids[] = {
  	{.compatible = "rockchip,rk3288-dp", .data = &rk3288_dp },
  	{.compatible = "rockchip,rk3399-edp", .data = &rk3399_edp },
  	{}
  };
  MODULE_DEVICE_TABLE(of, rockchip_dp_dt_ids);
+#endif
  
  struct platform_driver rockchip_dp_driver = {
  	.probe = rockchip_dp_probe,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] drm/rockchip: defined struct rockchip_dp_dt_ids[] under CONFIG_OF

From: Souptick Joarder <hidden>
Date: 2021-06-07 18:41:53 

On Wed, Jun 2, 2021 at 3:37 PM Robin Murphy [off-list ref] wrote:
On 2021-06-02 09:02, Souptick Joarder wrote:
quoted
Kernel test robot throws below warning when CONFIG_OF
is not set.
quoted
quoted
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:457:34:
warning: unused variable 'rockchip_dp_dt_ids' [-Wunused-const-variable]
    static const struct of_device_id rockchip_dp_dt_ids[] = {

Fixed it by defining rockchip_dp_dt_ids[] under CONFIG_OF.
I think the __maybe_unused annotation is generally preferred over
#ifdefs these days. However, since these drivers only work with
devicetree anyway, it probably makes more sense to just remove the
of_match_ptr() uses which lead to these warnings in the first place.
Ok. Will remove of_match_ptr().
Robin.
quoted
Reported-by: kernel test robot <redacted>
Signed-off-by: Souptick Joarder <redacted>
---
  drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index ade2327a10e2..9b79ebaeae97 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -454,12 +454,14 @@ static const struct rockchip_dp_chip_data rk3288_dp = {
      .chip_type = RK3288_DP,
  };

+#ifdef CONFIG_OF
  static const struct of_device_id rockchip_dp_dt_ids[] = {
      {.compatible = "rockchip,rk3288-dp", .data = &rk3288_dp },
      {.compatible = "rockchip,rk3399-edp", .data = &rk3399_edp },
      {}
  };
  MODULE_DEVICE_TABLE(of, rockchip_dp_dt_ids);
+#endif

  struct platform_driver rockchip_dp_driver = {
      .probe = rockchip_dp_probe,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help