From: Neil Armstrong <hidden> Date: 2021-06-01 09:01:53
According to Odroid-C4 & HC4 Schematics, the TF_3V3N_1V8_EN can be in Hi-Z for 3v3,
and since it's the default GPIOAO_6 mode at reset, let switch this GPIO as Open-Source
to drive for 1, and input for 0.
Fixes: 88d537bc92ca ("arm64: dts: meson: convert meson-sm1-odroid-c4 to dtsi")
Signed-off-by: Neil Armstrong <redacted>
---
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Neil Armstrong <hidden> Date: 2021-06-01 09:01:55
As described in the Odroid-C4 schematics, the HUB_5V regulator is controlled
by GPIOH_8 and in Open Drain since this GPIO doesn't support Push-Pull.
Fixes: 326e57518b0d ("arm64: dts: meson-sm1: add support for Hardkernel ODROID-C4")
Signed-off-by: Neil Armstrong <redacted>
---
arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -31,7 +31,7 @@ hub_5v: regulator-hub_5v {vin-supply=<&vcc_5v>;/* Connected to the Hub CHIPENABLE, LOW sets low power state */-gpio=<&gpioGPIOH_4GPIO_ACTIVE_HIGH>;+gpio=<&gpioGPIOH_8GPIO_OPEN_DRAIN>;enable-active-high;};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Neil Armstrong <hidden> Date: 2021-06-01 09:01:58
As described in the HC4 schematics, only the USB port B is used,
port A is left unconnected. Thus disable PHY0 and remove it from PHYs list.
Signed-off-by: Neil Armstrong <redacted>
---
arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
From: Neil Armstrong <hidden> Date: 2021-06-01 09:02:00
As described in the schematics of Odroid-C4 and Odroid-HC4, the TF_IO regulator
is enabled by the GPIOE_2 GPIO and gets it's supply from VCC_5V.
Fixes: 88d537bc92ca ("arm64: dts: meson: convert meson-sm1-odroid-c4 to dtsi")
Signed-off-by: Neil Armstrong <redacted>
---
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi | 5 +++++
1 file changed, 5 insertions(+)
From: Neil Armstrong <hidden> Date: 2021-06-01 09:02:08
As described in the HC4 schematics, GPIOH_8 controls the USB 5V and 12V
regulators used to power the SATA drives.
And is set as Open Drain since this GPIO doesn't support Push-Pull.
Signed-off-by: Neil Armstrong <redacted>
---
.../boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 31 +++++++++++++++++++
1 file changed, 31 insertions(+)
@@ -44,6 +44,32 @@ led-red {};};+/* Powers the SATA Disk 0 regulator, which is enabled when a disk load is detected */+p12v_0:regulator-p12v_0{+compatible="regulator-fixed";+regulator-name="P12V_0";+regulator-min-microvolt=<12000000>;+regulator-max-microvolt=<12000000>;+vin-supply=<&main_12v>;++gpio=<&gpioGPIOH_8GPIO_OPEN_DRAIN>;+enable-active-high;+regulator-always-on;+};++/* Powers the SATA Disk 1 regulator, which is enabled when a disk load is detected */+p12v_1:regulator-p12v_1{+compatible="regulator-fixed";+regulator-name="P12V_1";+regulator-min-microvolt=<12000000>;+regulator-max-microvolt=<12000000>;+vin-supply=<&main_12v>;++gpio=<&gpioGPIOH_8GPIO_OPEN_DRAIN>;+enable-active-high;+regulator-always-on;+};+sound{model="ODROID-HC4";};
From: Neil Armstrong <hidden> Date: 2021-06-01 09:02:10
From: Christian Hewitt <redacted>
Add a node for the XT25F128B SPI-NOR flash to make it accessible
from Linux.
Signed-off-by: Christian Hewitt <redacted>
Signed-off-by: Neil Armstrong <redacted>
---
.../boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Date: 2021-06-03 18:05:49
On Tue, Jun 1, 2021 at 11:01 AM Neil Armstrong [off-list ref] wrote:
According to Odroid-C4 & HC4 Schematics, the TF_3V3N_1V8_EN can be in Hi-Z for 3v3,
and since it's the default GPIOAO_6 mode at reset, let switch this GPIO as Open-Source
to drive for 1, and input for 0.
Fixes: 88d537bc92ca ("arm64: dts: meson: convert meson-sm1-odroid-c4 to dtsi")
Signed-off-by: Neil Armstrong <redacted>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Date: 2021-06-03 18:05:50
On Tue, Jun 1, 2021 at 11:01 AM Neil Armstrong [off-list ref] wrote:
As described in the schematics of Odroid-C4 and Odroid-HC4, the TF_IO regulator
is enabled by the GPIOE_2 GPIO and gets it's supply from VCC_5V.
Fixes: 88d537bc92ca ("arm64: dts: meson: convert meson-sm1-odroid-c4 to dtsi")
Signed-off-by: Neil Armstrong <redacted>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Date: 2021-06-03 18:09:00
On Tue, Jun 1, 2021 at 11:01 AM Neil Armstrong [off-list ref] wrote:
As described in the HC4 schematics, GPIOH_8 controls the USB 5V and 12V
regulators used to power the SATA drives.
And is set as Open Drain since this GPIO doesn't support Push-Pull.
Signed-off-by: Neil Armstrong <redacted>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Date: 2021-06-03 18:09:08
Hi Neil,
On Tue, Jun 1, 2021 at 11:01 AM Neil Armstrong [off-list ref] wrote:
As described in the Odroid-C4 schematics, the HUB_5V regulator is controlled
by GPIOH_8 and in Open Drain since this GPIO doesn't support Push-Pull.
Fixes: 326e57518b0d ("arm64: dts: meson-sm1: add support for Hardkernel ODROID-C4")
Signed-off-by: Neil Armstrong <redacted>
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Date: 2021-06-03 18:10:40
On Tue, Jun 1, 2021 at 11:01 AM Neil Armstrong [off-list ref] wrote:
As described in the HC4 schematics, only the USB port B is used,
port A is left unconnected. Thus disable PHY0 and remove it from PHYs list.
Signed-off-by: Neil Armstrong <redacted>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Date: 2021-06-03 18:11:19
On Tue, Jun 1, 2021 at 11:01 AM Neil Armstrong [off-list ref] wrote:
From: Christian Hewitt <redacted>
Add a node for the XT25F128B SPI-NOR flash to make it accessible
from Linux.
Signed-off-by: Christian Hewitt <redacted>
Signed-off-by: Neil Armstrong <redacted>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Neil Armstrong <hidden> Date: 2021-06-04 09:44:47
Hi,
On 03/06/2021 20:07, Martin Blumenstingl wrote:
Hi Neil,
On Tue, Jun 1, 2021 at 11:01 AM Neil Armstrong [off-list ref] wrote:
quoted
As described in the Odroid-C4 schematics, the HUB_5V regulator is controlled
by GPIOH_8 and in Open Drain since this GPIO doesn't support Push-Pull.
Fixes: 326e57518b0d ("arm64: dts: meson-sm1: add support for Hardkernel ODROID-C4")
Signed-off-by: Neil Armstrong <redacted>
my interpretation of page 32 of the schematics [0] is that GPIOH_8 manages VCC5V
GPIOH_4 is connected as RST_N to the RESET# pad of the USB hub -> this
seems to match the original regulator definition
You're right, but GPIOH_4 is already a GPIO HOG, so this regulator doesn't make any sense then,
and the GPIO for the VCC_5V regulator is missing, like in patch 5.
So I'll add:
+&vcc_5v {
+ gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
+ enable-active-high;
+};
in odroid.dtsi instead in this patch.
Not sure what to do about the regulator-hub_5v.
Neil
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Date: 2021-06-04 10:15:00
Hi Neil,
On Fri, Jun 4, 2021 at 11:43 AM Neil Armstrong [off-list ref] wrote:
[...]
So I'll add:
+&vcc_5v {
+ gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
+ enable-active-high;
+};
in odroid.dtsi instead in this patch.
that sounds good to me
Not sure what to do about the regulator-hub_5v.
maybe dropping this regulator overall? we're using gpio-hogs elsewhere
for the USB hub's reset line
or dropping the gpio-hog and keeping this regulator to manage GPIOH_4
Best regards,
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Neil Armstrong <hidden> Date: 2021-06-04 10:20:35
On 04/06/2021 12:13, Martin Blumenstingl wrote:
Hi Neil,
On Fri, Jun 4, 2021 at 11:43 AM Neil Armstrong [off-list ref] wrote:
[...]
quoted
So I'll add:
+&vcc_5v {
+ gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
+ enable-active-high;
+};
in odroid.dtsi instead in this patch.
that sounds good to me
quoted
Not sure what to do about the regulator-hub_5v.
maybe dropping this regulator overall? we're using gpio-hogs elsewhere
for the USB hub's reset line
or dropping the gpio-hog and keeping this regulator to manage GPIOH_4
I'll drop it completely, it makes no sense to have a regulator for a HUB reset anyway.
Neil