@@ -100,9 +100,6 @@#define SWAPPER_TABLE_SHIFT PMD_SHIFT#endif-/* The size of the initial kernel direct mapping */-#define SWAPPER_INIT_MAP_SIZE (_AC(1, UL) << SWAPPER_TABLE_SHIFT)-/**Initialmemorymapattributes.*/
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
'count - 1' is confusing and not comply with the real code running.
'count' actually represents the extra entries required, no need minus 1.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
arch/arm64/kernel/head.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
x5 is not used in the following map_memory. Instead,
__pa(__idmap_text_start) is stored in x3 which is used later.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
arch/arm64/kernel/head.S | 1 -
1 file changed, 1 deletion(-)
Up to here, the CPU boot mode can either be EL1 or EL2.
Correct the code comments a bit.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
arch/arm64/kernel/head.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Mark Rutland <mark.rutland@arm.com> Date: 2021-05-18 12:15:58
On Tue, May 18, 2021 at 06:14:02PM +0800, Dong Aisheng wrote:
Since commit cdef5f6e9e0e ("arm64: mm: allocate pagetables anywhere"),
arm64 kernel supports allocate pagetables anywhere and this macro
definition is not used anymore.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
@@ -100,9 +100,6 @@#define SWAPPER_TABLE_SHIFT PMD_SHIFT#endif-/* The size of the initial kernel direct mapping */-#define SWAPPER_INIT_MAP_SIZE (_AC(1, UL) << SWAPPER_TABLE_SHIFT)-/**Initialmemorymapattributes.*/
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Mark Rutland <mark.rutland@arm.com> Date: 2021-05-18 12:21:26
On Tue, May 18, 2021 at 06:14:04PM +0800, Dong Aisheng wrote:
x5 is not used in the following map_memory. Instead,
__pa(__idmap_text_start) is stored in x3 which is used later.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
It might be worth noting that this hasn't been used since commit:
0370b31e48454d8c ("arm64: Extend early page table code to allow for larger kernels")
Either way:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
From: Mark Rutland <mark.rutland@arm.com> Date: 2021-05-18 12:37:52
On Tue, May 18, 2021 at 06:14:03PM +0800, Dong Aisheng wrote:
'count - 1' is confusing and not comply with the real code running.
'count' actually represents the extra entries required, no need minus 1.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
This looks right to me, but I'm not all that familiar with this code.
Steve, does this make sense to you?
Mark.
On Tue, May 18, 2021 at 01:35:11PM +0100, Mark Rutland wrote:
On Tue, May 18, 2021 at 06:14:03PM +0800, Dong Aisheng wrote:
quoted
'count - 1' is confusing and not comply with the real code running.
'count' actually represents the extra entries required, no need minus 1.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
This looks right to me, but I'm not all that familiar with this code.
Steve, does this make sense to you?
Mark.
The comment was updated to match the code. The code also looks ok to me:
iend is inclusive and count denotes the extra entries required rather
than the actual number of entries.
Also cc'ing Will, I think he missed this series.
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
@@ -100,9 +100,6 @@#define SWAPPER_TABLE_SHIFT PMD_SHIFT#endif-/* The size of the initial kernel direct mapping */-#define SWAPPER_INIT_MAP_SIZE (_AC(1, UL) << SWAPPER_TABLE_SHIFT)
+ Will
On Tue, May 18, 2021 at 06:14:04PM +0800, Dong Aisheng wrote:
x5 is not used in the following map_memory. Instead,
__pa(__idmap_text_start) is stored in x3 which is used later.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>