[PATCH] usb: dwc3: remove repeated setting of current_dr_role

Subsystems: designware usb3 drd ip driver, the rest, usb subsystem

STALE1961d LANDED

Landed in mainline as 374ac7448caa on 2021-05-10.

2 messages, 2 authors, 2021-05-06 · open the first message on its own page

[PATCH] usb: dwc3: remove repeated setting of current_dr_role

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
Date: 2021-05-06 07:26:27

dwc3_set_prtcap() already sets current_dr_role as
DWC3_GCTL_PRTCAP_OTG, so remove the repeated one.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/dwc3/drd.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
index e2b68bb770d1..8fcbac10510c 100644
--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -596,7 +596,6 @@ int dwc3_drd_init(struct dwc3 *dwc)
 		dwc3_drd_update(dwc);
 	} else {
 		dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_OTG);
-		dwc->current_dr_role = DWC3_GCTL_PRTCAP_OTG;
 
 		/* use OTG block to get ID event */
 		irq = dwc3_otg_get_irq(dwc);
-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] usb: dwc3: remove repeated setting of current_dr_role

From: Felipe Balbi <balbi@kernel.org>
Date: 2021-05-06 08:55:05

Hi,

Chunfeng Yun [off-list ref] writes:
dwc3_set_prtcap() already sets current_dr_role as
DWC3_GCTL_PRTCAP_OTG, so remove the repeated one.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
looks correct to me:

Acked-by: Felipe Balbi <balbi@kernel.org>

-- 
balbi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help