[PATCH 00/24] Rid W=1 warnings from USB
1915d
6 messages,
3 authors,
2021-05-27 · open the first message on its own page
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (24):
usb: cdns3: core: Fix a couple of incorrectly documented function
names
usb: dwc2: platform: Provide function name for
'dwc2_check_core_version()'
usb: common: ulpi: Add leading underscores for function name
'__ulpi_register_driver()'
usb: cdns3: cdns3-plat: Fix incorrect naming of function
'cdns3_plat_remove()'
usb: dwc2: params: Fix naming of 'dwc2_get_hwparams()' in the docs
usb: isp1760: isp1760-udc: Provide missing description for 'udc' param
usb: cdns3: cdns3-gadget: Fix a bunch of kernel-doc related formatting
issues
usb: cdns3: cdns3-ti: File headers are not good candidates for
kernel-doc
usb: cdns3: cdns3-ep0: Fix a few kernel-doc formatting issues
usb: cdns3: cdns3-imx: File headers are not good candidates for
kernel-doc
usb: dwc2: hcd_queue: Fix typeo in function name
'dwc2_hs_pmap_unschedule()'
usb: dwc2: pci: Fix possible copy/paste issue
usb: chipidea: core: Fix incorrectly documented function
'ci_usb_phy_exit()'
usb: chipidea: otg: Fix formatting and missing documentation issues
usb: dwc2: gadget: Repair 'dwc2_hsotg_core_init_disconnected()'s
documentation
usb: chipidea: udc: Fix incorrectly documented function
'hw_port_is_high_speed()'
usb: host: xhci: Remove unused variable 'len'
usb: gadget: udc: pxa27x_udc: Fix documentation for
'pxa27x_udc_start()'
usb: gadget: udc: udc-xilinx: Place correct function names into the
headers
usb: cdns3: cdns3-gadget: Provide correct function naming for
'__cdns3_gadget_ep_queue()'
usb: host: xhci: Move array of structs from the stack onto the heap
usb: host: xhci: Document xhci_get_endpoint_index()'s 'desc' param
usb: cdns3: cdnsp-gadget: Provide function name for
'cdnsp_find_next_ext_cap()'
usb: typec: ucsi: Fix copy/paste issue for 'ucsi_set_drvdata()'
drivers/usb/cdns3/cdns3-ep0.c | 6 ++---
drivers/usb/cdns3/cdns3-gadget.c | 34 ++++++++++++++---------------
drivers/usb/cdns3/cdns3-imx.c | 2 +-
drivers/usb/cdns3/cdns3-plat.c | 2 +-
drivers/usb/cdns3/cdns3-ti.c | 2 +-
drivers/usb/cdns3/cdnsp-gadget.c | 3 ++-
drivers/usb/cdns3/core.c | 4 ++--
drivers/usb/chipidea/core.c | 2 +-
drivers/usb/chipidea/otg.c | 9 ++++----
drivers/usb/chipidea/udc.c | 2 +-
drivers/usb/common/ulpi.c | 2 +-
drivers/usb/dwc2/gadget.c | 2 +-
drivers/usb/dwc2/hcd_queue.c | 2 +-
drivers/usb/dwc2/params.c | 4 ++--
drivers/usb/dwc2/pci.c | 2 +-
drivers/usb/dwc2/platform.c | 2 +-
drivers/usb/gadget/udc/pxa27x_udc.c | 2 +-
drivers/usb/gadget/udc/udc-xilinx.c | 4 ++--
drivers/usb/host/xhci.c | 19 +++++++++++-----
drivers/usb/isp1760/isp1760-udc.c | 1 +
drivers/usb/typec/ucsi/ucsi.c | 2 +-
21 files changed, 59 insertions(+), 49 deletions(-)
Cc: Aswath Govindraju <redacted>
Cc: Ben Dooks <redacted>
Cc: Daniel Mack <daniel@zonque.org>
Cc: David Lopo <redacted>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-usb@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>
Cc: Matthijs Kooijman <redacted>
Cc: Michal Simek <redacted>
Cc: Minas Harutyunyan <hminas@synopsys.com>
Cc: NXP Linux Team <redacted>
Cc: Pawel Jez <redacted>
Cc: Pawel Laszczak <pawell@cadence.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Peter Chen <peter.chen@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Roger Quadros <rogerq@kernel.org>
Cc: Rui Miguel Silva <rui.silva@linaro.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/usb/cdns3/cdns3-imx.c:21: warning: expecting prototype for cdns3(). Prototype was for USB3_CORE_CTRL1() instead
Cc: Peter Chen <peter.chen@kernel.org>
Cc: Pawel Laszczak <pawell@cadence.com>
Cc: Roger Quadros <rogerq@kernel.org>
Cc: Aswath Govindraju <redacted>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <redacted>
Cc: linux-usb@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <redacted>
---
drivers/usb/cdns3/cdns3-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/cdns3/cdns3-imx.c b/drivers/usb/cdns3/cdns3-imx.c
index 74e758dc08955..59860d1753fd5 100644
--- a/drivers/usb/cdns3/cdns3-imx.c
+++ b/drivers/usb/cdns3/cdns3-imx.c @@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
- /** + /* * cdns3 - imx . c - NXP i . MX specific Glue layer for Cadence USB Controller
*
* Copyright ( C ) 2019 NXP --
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/usb/gadget/udc/pxa27x_udc.c:1749: warning: expecting prototype for pxa27x_start(). Prototype was for pxa27x_udc_start() instead
Cc: Daniel Mack <daniel@zonque.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-usb@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/usb/gadget/udc/pxa27x_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
index ce57961dfd2d6..b2759b04b8e94 100644
--- a/drivers/usb/gadget/udc/pxa27x_udc.c
+++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -1730,7 +1730,7 @@ static void udc_enable(struct pxa_udc *udc)
}
/**
- * pxa27x_start - Register gadget driver + * pxa27x_udc_start - Register gadget driver * @ g : gadget
* @ driver : gadget driver
* --
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/usb/gadget/udc/udc-xilinx.c:802: warning: expecting prototype for xudc_ep_enable(). Prototype was for __xudc_ep_enable() instead
drivers/usb/gadget/udc/udc-xilinx.c:997: warning: expecting prototype for xudc_ep0_queue(). Prototype was for __xudc_ep0_queue() instead
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michal Simek <redacted>
Cc: linux-usb@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <redacted>
---
drivers/usb/gadget/udc/udc-xilinx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
index 72f2ea062d554..fb4ffedd6f0dd 100644
--- a/drivers/usb/gadget/udc/udc-xilinx.c
+++ b/drivers/usb/gadget/udc/udc-xilinx.c @@ -791,7 +791,7 @@ static int xudc_ep_set_halt(struct usb_ep *_ep, int value)
}
/**
- * xudc_ep_enable - Enables the given endpoint . + * __xudc_ep_enable - Enables the given endpoint . * @ ep : pointer to the xusb endpoint structure .
* @ desc : pointer to usb endpoint descriptor .
* @@ -987,7 +987,7 @@ static void xudc_free_request(struct usb_ep *_ep, struct usb_request *_req)
}
/**
- * xudc_ep0_queue - Adds the request to endpoint 0 queue . + * __xudc_ep0_queue - Adds the request to endpoint 0 queue . * @ ep0 : pointer to the xusb endpoint 0 structure .
* @ req : pointer to the xusb request structure .
* --
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 5/26/21 3:00 PM, Lee Jones wrote: Fixes the following W=1 kernel build warning(s):
drivers/usb/gadget/udc/pxa27x_udc.c:1749: warning: expecting prototype for pxa27x_start(). Prototype was for pxa27x_udc_start() instead
Acked-by: Daniel Mack <daniel@zonque.org>
Thanks!
quoted hunk Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-usb@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/usb/gadget/udc/pxa27x_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
index ce57961dfd2d6..b2759b04b8e94 100644
--- a/drivers/usb/gadget/udc/pxa27x_udc.c
+++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -1730,7 +1730,7 @@ static void udc_enable(struct pxa_udc *udc)
}
/**
- * pxa27x_start - Register gadget driver + * pxa27x_udc_start - Register gadget driver * @ g : gadget
* @ driver : gadget driver
*
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 21-05-26 14:00:13, Lee Jones wrote: This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
For chipidea and cdns3 parts:
Acked-by: Peter Chen <peter.chen@kernel.org>
Peter
Lee Jones (24):
usb: cdns3: core: Fix a couple of incorrectly documented function
names
usb: dwc2: platform: Provide function name for
'dwc2_check_core_version()'
usb: common: ulpi: Add leading underscores for function name
'__ulpi_register_driver()'
usb: cdns3: cdns3-plat: Fix incorrect naming of function
'cdns3_plat_remove()'
usb: dwc2: params: Fix naming of 'dwc2_get_hwparams()' in the docs
usb: isp1760: isp1760-udc: Provide missing description for 'udc' param
usb: cdns3: cdns3-gadget: Fix a bunch of kernel-doc related formatting
issues
usb: cdns3: cdns3-ti: File headers are not good candidates for
kernel-doc
usb: cdns3: cdns3-ep0: Fix a few kernel-doc formatting issues
usb: cdns3: cdns3-imx: File headers are not good candidates for
kernel-doc
usb: dwc2: hcd_queue: Fix typeo in function name
'dwc2_hs_pmap_unschedule()'
usb: dwc2: pci: Fix possible copy/paste issue
usb: chipidea: core: Fix incorrectly documented function
'ci_usb_phy_exit()'
usb: chipidea: otg: Fix formatting and missing documentation issues
usb: dwc2: gadget: Repair 'dwc2_hsotg_core_init_disconnected()'s
documentation
usb: chipidea: udc: Fix incorrectly documented function
'hw_port_is_high_speed()'
usb: host: xhci: Remove unused variable 'len'
usb: gadget: udc: pxa27x_udc: Fix documentation for
'pxa27x_udc_start()'
usb: gadget: udc: udc-xilinx: Place correct function names into the
headers
usb: cdns3: cdns3-gadget: Provide correct function naming for
'__cdns3_gadget_ep_queue()'
usb: host: xhci: Move array of structs from the stack onto the heap
usb: host: xhci: Document xhci_get_endpoint_index()'s 'desc' param
usb: cdns3: cdnsp-gadget: Provide function name for
'cdnsp_find_next_ext_cap()'
usb: typec: ucsi: Fix copy/paste issue for 'ucsi_set_drvdata()'
drivers/usb/cdns3/cdns3-ep0.c | 6 ++---
drivers/usb/cdns3/cdns3-gadget.c | 34 ++++++++++++++---------------
drivers/usb/cdns3/cdns3-imx.c | 2 +-
drivers/usb/cdns3/cdns3-plat.c | 2 +-
drivers/usb/cdns3/cdns3-ti.c | 2 +-
drivers/usb/cdns3/cdnsp-gadget.c | 3 ++-
drivers/usb/cdns3/core.c | 4 ++--
drivers/usb/chipidea/core.c | 2 +-
drivers/usb/chipidea/otg.c | 9 ++++----
drivers/usb/chipidea/udc.c | 2 +-
drivers/usb/common/ulpi.c | 2 +-
drivers/usb/dwc2/gadget.c | 2 +-
drivers/usb/dwc2/hcd_queue.c | 2 +-
drivers/usb/dwc2/params.c | 4 ++--
drivers/usb/dwc2/pci.c | 2 +-
drivers/usb/dwc2/platform.c | 2 +-
drivers/usb/gadget/udc/pxa27x_udc.c | 2 +-
drivers/usb/gadget/udc/udc-xilinx.c | 4 ++--
drivers/usb/host/xhci.c | 19 +++++++++++-----
drivers/usb/isp1760/isp1760-udc.c | 1 +
drivers/usb/typec/ucsi/ucsi.c | 2 +-
21 files changed, 59 insertions(+), 49 deletions(-)
Cc: Aswath Govindraju <redacted>
Cc: Ben Dooks <redacted>
Cc: Daniel Mack <daniel@zonque.org>
Cc: David Lopo <redacted>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-usb@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>
Cc: Matthijs Kooijman <redacted>
Cc: Michal Simek <redacted>
Cc: Minas Harutyunyan <hminas@synopsys.com>
Cc: NXP Linux Team <redacted>
Cc: Pawel Jez <redacted>
Cc: Pawel Laszczak <pawell@cadence.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Peter Chen <peter.chen@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Roger Quadros <rogerq@kernel.org>
Cc: Rui Miguel Silva <rui.silva@linaro.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
--
2.31.1
--
Thanks,
Peter Chen
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel