# Re: \[PATCH 2/3\] mfd: mt6397: keys: use named IRQs instead of index

- From: Lee Jones \<hidden\>
- Date: 2021-05-19 10:55:14 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2021/05/1383283
- Thread: https://ratatoskr.run/linux-arm-kernel/2021/05/6359702/t.md

```text
On Thu, 06 May 2021, Mattijs Korpershoek wrote:

> Some pmics of the mt6397 family (such as MT6358), have two IRQs per
> physical key: one for press event, another for release event.
> 
> The mtk-pmic-keys driver assumes that each key only has one
> IRQ. The key index and the RES_IRQ resource index have a 1/1 mapping.
> 
> This won't work for MT6358, as we have multiple resources (2) for one key.
> 
> To prepare mtk-pmic-keys to support MT6358, retrieve IRQs by name
> instead of by index.
> 
> Note: The keys_resources are not part of the device-tree bindings so
> this won't break any DT schemas.
> 
> Signed-off-by: Mattijs Korpershoek <redacted>
> ---
>  drivers/mfd/mt6397-core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
```
