[PATCH -next] dmaengine: stedma40: add missing iounmap() on error in d40_probe()

Subsystems: arm/nomadik/ux500 architectures, dma generic offload engine subsystem, the rest

STALE1922d LANDED

Landed in mainline as fffdaba402ce on 2021-05-31.

3 messages, 3 authors, 2021-05-31 · open the first message on its own page

[PATCH -next] dmaengine: stedma40: add missing iounmap() on error in d40_probe()

From: Yang Yingliang <hidden>
Date: 2021-05-18 14:09:09

Add the missing iounmap() before return from d40_probe()
in the error handling case.

Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Yang Yingliang <redacted>
---
 drivers/dma/ste_dma40.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 265d7c07b348..e1827393143f 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -3675,6 +3675,9 @@ static int __init d40_probe(struct platform_device *pdev)
 
 	kfree(base->lcla_pool.base_unaligned);
 
+	if (base->lcpa_base)
+		iounmap(base->lcpa_base);
+
 	if (base->phy_lcpa)
 		release_mem_region(base->phy_lcpa,
 				   base->lcpa_size);
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH -next] dmaengine: stedma40: add missing iounmap() on error in d40_probe()

From: Linus Walleij <hidden>
Date: 2021-05-22 00:01:38

On Tue, May 18, 2021 at 4:09 PM Yang Yingliang [off-list ref] wrote:
Add the missing iounmap() before return from d40_probe()
in the error handling case.

Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Yang Yingliang <redacted>
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH -next] dmaengine: stedma40: add missing iounmap() on error in d40_probe()

From: Vinod Koul <vkoul@kernel.org>
Date: 2021-05-31 04:17:46

On 18-05-21, 22:11, Yang Yingliang wrote:
Add the missing iounmap() before return from d40_probe()
in the error handling case.
Applied, thanks

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help