From: Jianjun Wang <hidden> Date: 2021-05-14 07:00:31
These series patches add support for disable dvfsrc voltage request.
Jianjun Wang (2):
dt-bindings: PCI: mediatek-gen3: Add property to disable dvfsrc
voltage request
PCI: mediatek-gen3: Add support for disable dvfsrc voltage request
.../bindings/pci/mediatek-pcie-gen3.yaml | 8 +++++
drivers/pci/controller/pcie-mediatek-gen3.c | 32 +++++++++++++++++++
2 files changed, 40 insertions(+)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Jianjun Wang <hidden> Date: 2021-05-14 07:00:28
PCIe Gen3 PHY layer cannot work properly when the requested voltage
is lower than a specific level(e.g. 0.55V, it's depends on
the chip manufacturing process).
When the dvfsrc feature is implemented, the requested voltage
may be reduced to a lower level in suspend mode, hence that
the MAC layer will assert a HW signal to request the dvfsrc
to raise voltage to normal mode, and it will wait the voltage
ready signal which is derived from dvfsrc to determine whether
the LTSSM can start normally.
When the dvfsrc feature is not implemented, the MAC layer still
assert the voltage request to dvfsrc when exit suspend mode,
but will not receive the voltage ready signal, in this case,
the LTSSM cannot start normally, and the PCIe link will be failed.
Add support for disable dvfsrc voltage request. If the property of
"disable-dvfsrc-vlt-req" is presented in device node, we assume that
the requested voltage is always higher enough to keep the PCIe Gen3
PHY active, and the voltage request to dvfsrc should be disabled.
Signed-off-by: Jianjun Wang <redacted>
---
drivers/pci/controller/pcie-mediatek-gen3.c | 32 +++++++++++++++++++++
1 file changed, 32 insertions(+)
From: Jianjun Wang <hidden> Date: 2021-05-14 07:00:35
Add property to disable dvfsrc voltage request, if this property
is presented, we assume that the requested voltage is always
higher enough to keep the PCIe controller active.
Signed-off-by: Jianjun Wang <redacted>
---
.../devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
@@ -96,6 +96,12 @@ properties:phys:maxItems:1+disable-dvfsrc-vlt-req:+description:Disable dvfsrc voltage request, if this property is presented,+we assume that the requested voltage is always higher enough to keep+the PCIe controller active.+type:boolean+'#interrupt-cells':const:1
From: Jianjun Wang <hidden> Date: 2021-05-26 07:44:51
Hi Bjorn, Rob, Lorenzo,
Could you please help to take a look at this patch, I'm not sure if this
is a good solution, and I really need your suggestions.
Thanks.
On Fri, 2021-05-14 at 14:59 +0800, Jianjun Wang wrote:
quoted hunk
PCIe Gen3 PHY layer cannot work properly when the requested voltage
is lower than a specific level(e.g. 0.55V, it's depends on
the chip manufacturing process).
When the dvfsrc feature is implemented, the requested voltage
may be reduced to a lower level in suspend mode, hence that
the MAC layer will assert a HW signal to request the dvfsrc
to raise voltage to normal mode, and it will wait the voltage
ready signal which is derived from dvfsrc to determine whether
the LTSSM can start normally.
When the dvfsrc feature is not implemented, the MAC layer still
assert the voltage request to dvfsrc when exit suspend mode,
but will not receive the voltage ready signal, in this case,
the LTSSM cannot start normally, and the PCIe link will be failed.
Add support for disable dvfsrc voltage request. If the property of
"disable-dvfsrc-vlt-req" is presented in device node, we assume that
the requested voltage is always higher enough to keep the PCIe Gen3
PHY active, and the voltage request to dvfsrc should be disabled.
Signed-off-by: Jianjun Wang <redacted>
---
drivers/pci/controller/pcie-mediatek-gen3.c | 32 +++++++++++++++++++++
1 file changed, 32 insertions(+)