On Wed, 12 May 2021 at 20:22, Greg Kroah-Hartman
[off-list ref] wrote:
This is the start of the stable review cycle for the 5.4.119 release.
There are 244 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Fri, 14 May 2021 14:47:09 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.119-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Build regression detected.
Alexandru Elisei [off-list ref]
KVM: arm64: Initialize VCPU mdcr_el2 before loading it
stable rc 5.4 arm axm55xx_defconfig builds failed due to these
warnings / errors.
- arm (axm55xx_defconfig) with gcc-8,9 and 10 failed
arch/arm/kvm/../../../virt/kvm/arm/arm.c: In function 'kvm_vcpu_first_run_init':
arch/arm/kvm/../../../virt/kvm/arm/arm.c:582:2: error: implicit
declaration of function 'kvm_arm_vcpu_init_debug'; did you mean
'kvm_arm_init_debug'? [-Werror=implicit-function-declaration]
kvm_arm_vcpu_init_debug(vcpu);
^~~~~~~~~~~~~~~~~~~~~~~
kvm_arm_init_debug
cc1: some warnings being treated as errors
steps to reproduce:
--------------------
#!/bin/sh
# TuxMake is a command line tool and Python library that provides
# portable and repeatable Linux kernel builds across a variety of
# architectures, toolchains, kernel configurations, and make targets.
#
# TuxMake supports the concept of runtimes.
# See https://docs.tuxmake.org/runtimes/, for that to work it requires
# that you install podman or docker on your system.
#
# To install tuxmake on your system globally:
# sudo pip3 install -U tuxmake
#
# See https://docs.tuxmake.org/ for complete documentation.
tuxmake --runtime podman --target-arch arm --toolchain gcc-8 --kconfig
axm55xx_defconfig
ref:
https://builds.tuxbuild.com/1sRT0HOyHnZ8N5ktJmaEcMIQZL0/
--
Linaro LKFT
https://lkft.linaro.org
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Alexandru Elisei <hidden> Date: 2021-05-12 19:35:08
Hi Naresh,
Thank you for the report!
On 5/12/21 5:47 PM, Naresh Kamboju wrote:
On Wed, 12 May 2021 at 20:22, Greg Kroah-Hartman
[off-list ref] wrote:
quoted
This is the start of the stable review cycle for the 5.4.119 release.
There are 244 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Fri, 14 May 2021 14:47:09 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.119-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Build regression detected.
quoted
Alexandru Elisei [off-list ref]
KVM: arm64: Initialize VCPU mdcr_el2 before loading it
stable rc 5.4 arm axm55xx_defconfig builds failed due to these
warnings / errors.
- arm (axm55xx_defconfig) with gcc-8,9 and 10 failed
arch/arm/kvm/../../../virt/kvm/arm/arm.c: In function 'kvm_vcpu_first_run_init':
arch/arm/kvm/../../../virt/kvm/arm/arm.c:582:2: error: implicit
declaration of function 'kvm_arm_vcpu_init_debug'; did you mean
'kvm_arm_init_debug'? [-Werror=implicit-function-declaration]
kvm_arm_vcpu_init_debug(vcpu);
^~~~~~~~~~~~~~~~~~~~~~~
kvm_arm_init_debug
cc1: some warnings being treated as errors
This is my fault, in Linux v5.4 KVM for arm is still around, and there's no
prototype for the function when compiling for arm. I suspect that's also the case
for v4.19.
I made this change to get it to build:
$ git diff
int cpu) {}
static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_init_debug(void) {}
+static inline void kvm_arm_vcpu_init_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_clear_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) {}
which matches the stub for kvm_arm_init_debug(). I can spin a patch out of it and
send it for 5.4 and 4.19. Marc, what do you think?
Thanks,
Alex
steps to reproduce:
--------------------
#!/bin/sh
# TuxMake is a command line tool and Python library that provides
# portable and repeatable Linux kernel builds across a variety of
# architectures, toolchains, kernel configurations, and make targets.
#
# TuxMake supports the concept of runtimes.
# See https://docs.tuxmake.org/runtimes/, for that to work it requires
# that you install podman or docker on your system.
#
# To install tuxmake on your system globally:
# sudo pip3 install -U tuxmake
#
# See https://docs.tuxmake.org/ for complete documentation.
tuxmake --runtime podman --target-arch arm --toolchain gcc-8 --kconfig
axm55xx_defconfig
ref:
https://builds.tuxbuild.com/1sRT0HOyHnZ8N5ktJmaEcMIQZL0/
--
Linaro LKFT
https://lkft.linaro.org
From: Marc Zyngier <maz@kernel.org> Date: 2021-05-12 19:35:10
On Wed, 12 May 2021 18:00:16 +0100,
Alexandru Elisei [off-list ref] wrote:
quoted hunk
Hi Naresh,
Thank you for the report!
On 5/12/21 5:47 PM, Naresh Kamboju wrote:
quoted
On Wed, 12 May 2021 at 20:22, Greg Kroah-Hartman
[off-list ref] wrote:
quoted
This is the start of the stable review cycle for the 5.4.119 release.
There are 244 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Fri, 14 May 2021 14:47:09 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.119-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Build regression detected.
quoted
Alexandru Elisei [off-list ref]
KVM: arm64: Initialize VCPU mdcr_el2 before loading it
stable rc 5.4 arm axm55xx_defconfig builds failed due to these
warnings / errors.
- arm (axm55xx_defconfig) with gcc-8,9 and 10 failed
arch/arm/kvm/../../../virt/kvm/arm/arm.c: In function 'kvm_vcpu_first_run_init':
arch/arm/kvm/../../../virt/kvm/arm/arm.c:582:2: error: implicit
declaration of function 'kvm_arm_vcpu_init_debug'; did you mean
'kvm_arm_init_debug'? [-Werror=implicit-function-declaration]
kvm_arm_vcpu_init_debug(vcpu);
^~~~~~~~~~~~~~~~~~~~~~~
kvm_arm_init_debug
cc1: some warnings being treated as errors
This is my fault, in Linux v5.4 KVM for arm is still around, and
there's no prototype for the function when compiling for arm. I
suspect that's also the case for v4.19.
I made this change to get it to build:
$ git diff
int cpu) {}
static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_init_debug(void) {}
+static inline void kvm_arm_vcpu_init_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_clear_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) {}
which matches the stub for kvm_arm_init_debug(). I can spin a patch
out of it and send it for 5.4 and 4.19. Marc, what do you think?
Ideally, we'd drop the patch in its current form from 5.4 and 4.19,
and send an updated patch with this hunk to fix the 32bit build.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Wed, May 12, 2021 at 06:00:16PM +0100, Alexandru Elisei wrote:
Hi Naresh,
Thank you for the report!
On 5/12/21 5:47 PM, Naresh Kamboju wrote:
quoted
On Wed, 12 May 2021 at 20:22, Greg Kroah-Hartman
[off-list ref] wrote:
quoted
This is the start of the stable review cycle for the 5.4.119 release.
There are 244 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Fri, 14 May 2021 14:47:09 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.119-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Build regression detected.
quoted
Alexandru Elisei [off-list ref]
KVM: arm64: Initialize VCPU mdcr_el2 before loading it
stable rc 5.4 arm axm55xx_defconfig builds failed due to these
warnings / errors.
- arm (axm55xx_defconfig) with gcc-8,9 and 10 failed
arch/arm/kvm/../../../virt/kvm/arm/arm.c: In function 'kvm_vcpu_first_run_init':
arch/arm/kvm/../../../virt/kvm/arm/arm.c:582:2: error: implicit
declaration of function 'kvm_arm_vcpu_init_debug'; did you mean
'kvm_arm_init_debug'? [-Werror=implicit-function-declaration]
kvm_arm_vcpu_init_debug(vcpu);
^~~~~~~~~~~~~~~~~~~~~~~
kvm_arm_init_debug
cc1: some warnings being treated as errors
This is my fault, in Linux v5.4 KVM for arm is still around, and there's no
prototype for the function when compiling for arm. I suspect that's also the case
for v4.19.
int cpu) {}
static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_init_debug(void) {}
+static inline void kvm_arm_vcpu_init_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_clear_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) {}
which matches the stub for kvm_arm_init_debug(). I can spin a patch out of it and
send it for 5.4 and 4.19. Marc, what do you think?
Thanks,
Alex
quoted
steps to reproduce:
--------------------
#!/bin/sh
# TuxMake is a command line tool and Python library that provides
# portable and repeatable Linux kernel builds across a variety of
# architectures, toolchains, kernel configurations, and make targets.
#
# TuxMake supports the concept of runtimes.
# See https://docs.tuxmake.org/runtimes/, for that to work it requires
# that you install podman or docker on your system.
#
# To install tuxmake on your system globally:
# sudo pip3 install -U tuxmake
#
# See https://docs.tuxmake.org/ for complete documentation.
tuxmake --runtime podman --target-arch arm --toolchain gcc-8 --kconfig
axm55xx_defconfig
ref:
https://builds.tuxbuild.com/1sRT0HOyHnZ8N5ktJmaEcMIQZL0/
--
Linaro LKFT
https://lkft.linaro.org
On Wed, May 12, 2021 at 06:02:37PM +0100, Marc Zyngier wrote:
On Wed, 12 May 2021 18:00:16 +0100,
Alexandru Elisei [off-list ref] wrote:
quoted
Hi Naresh,
Thank you for the report!
On 5/12/21 5:47 PM, Naresh Kamboju wrote:
quoted
On Wed, 12 May 2021 at 20:22, Greg Kroah-Hartman
[off-list ref] wrote:
quoted
This is the start of the stable review cycle for the 5.4.119 release.
There are 244 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Fri, 14 May 2021 14:47:09 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.119-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Build regression detected.
quoted
Alexandru Elisei [off-list ref]
KVM: arm64: Initialize VCPU mdcr_el2 before loading it
stable rc 5.4 arm axm55xx_defconfig builds failed due to these
warnings / errors.
- arm (axm55xx_defconfig) with gcc-8,9 and 10 failed
arch/arm/kvm/../../../virt/kvm/arm/arm.c: In function 'kvm_vcpu_first_run_init':
arch/arm/kvm/../../../virt/kvm/arm/arm.c:582:2: error: implicit
declaration of function 'kvm_arm_vcpu_init_debug'; did you mean
'kvm_arm_init_debug'? [-Werror=implicit-function-declaration]
kvm_arm_vcpu_init_debug(vcpu);
^~~~~~~~~~~~~~~~~~~~~~~
kvm_arm_init_debug
cc1: some warnings being treated as errors
This is my fault, in Linux v5.4 KVM for arm is still around, and
there's no prototype for the function when compiling for arm. I
suspect that's also the case for v4.19.
I made this change to get it to build:
$ git diff
int cpu) {}
static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_init_debug(void) {}
+static inline void kvm_arm_vcpu_init_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_clear_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) {}
which matches the stub for kvm_arm_init_debug(). I can spin a patch
out of it and send it for 5.4 and 4.19. Marc, what do you think?
Ideally, we'd drop the patch in its current form from 5.4 and 4.19,
and send an updated patch with this hunk to fix the 32bit build.
That would be great. Do you want to do it for this set of releases
(i.e. today/tomorrow) or have me just drop this now and someone will
send me an updated version later when they get a chance?
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
int cpu) {}
static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_init_debug(void) {}
+static inline void kvm_arm_vcpu_init_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_clear_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) {}
which matches the stub for kvm_arm_init_debug(). I can spin a patch
out of it and send it for 5.4 and 4.19. Marc, what do you think?
Ideally, we'd drop the patch in its current form from 5.4 and 4.19,
and send an updated patch with this hunk to fix the 32bit build.
Yes please. I've dropped it from 5.4 and 4.19 and we can queue up a
fixed backport for the next round of releases.
--
Thanks,
Sasha
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Alex,
On Wed, 12 May 2021 at 22:29, Alexandru Elisei [off-list ref] wrote:
quoted hunk
Hi Naresh,
Thank you for the report!
On 5/12/21 5:47 PM, Naresh Kamboju wrote:
quoted
On Wed, 12 May 2021 at 20:22, Greg Kroah-Hartman
[off-list ref] wrote:
quoted
This is the start of the stable review cycle for the 5.4.119 release.
There are 244 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Fri, 14 May 2021 14:47:09 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.119-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Build regression detected.
quoted
Alexandru Elisei [off-list ref]
KVM: arm64: Initialize VCPU mdcr_el2 before loading it
stable rc 5.4 arm axm55xx_defconfig builds failed due to these
warnings / errors.
- arm (axm55xx_defconfig) with gcc-8,9 and 10 failed
arch/arm/kvm/../../../virt/kvm/arm/arm.c: In function 'kvm_vcpu_first_run_init':
arch/arm/kvm/../../../virt/kvm/arm/arm.c:582:2: error: implicit
declaration of function 'kvm_arm_vcpu_init_debug'; did you mean
'kvm_arm_init_debug'? [-Werror=implicit-function-declaration]
kvm_arm_vcpu_init_debug(vcpu);
^~~~~~~~~~~~~~~~~~~~~~~
kvm_arm_init_debug
cc1: some warnings being treated as errors
This is my fault, in Linux v5.4 KVM for arm is still around, and there's no
prototype for the function when compiling for arm. I suspect that's also the case
for v4.19.
I made this change to get it to build:
$ git diff
int cpu) {}
static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_init_debug(void) {}
+static inline void kvm_arm_vcpu_init_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_clear_debug(struct kvm_vcpu *vcpu) {}
static inline void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) {}
which matches the stub for kvm_arm_init_debug(). I can spin a patch out of it and
send it for 5.4 and 4.19. Marc, what do you think?
FYI,
This proposed fix patch applied and built PASS on the arm.
(you may apply this patch for the next round of stable rc review)
- Naresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel