Re: [PATCH v4 03/10] dt-bindings: mmc: rockchip-dw-mshc: add description for rk3568
From: Rob Herring <robh@kernel.org>
Date: 2021-04-30 21:13:49
Also in:
linux-devicetree, linux-i2c, linux-mmc, linux-rockchip, linux-serial, linux-watchdog, lkml
On Thu, Apr 29, 2021 at 04:11:44PM +0800, cl@rock-chips.com wrote:
quoted hunk ↗ jump to hunk
From: Liang Chen <redacted> add "rockchip,rk3568-dw-mshc", "rockchip,rk3288-dw-mshc" for mmc nodes on a rk3568 platform to rockchip-dw-mshc.yaml. Signed-off-by: Liang Chen <redacted> --- .../devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml index 3762f1c8de96..eaa3b0ef24f6 100644 --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml@@ -29,21 +29,14 @@ properties: - const: rockchip,rk3288-dw-mshc - items: - enum: - # for Rockchip PX30 - rockchip,px30-dw-mshc - # for Rockchip RK3036 - rockchip,rk3036-dw-mshc - # for Rockchip RK322x - rockchip,rk3228-dw-mshc - # for Rockchip RK3308 - rockchip,rk3308-dw-mshc - # for Rockchip RK3328 - rockchip,rk3328-dw-mshc - # for Rockchip RK3368 - rockchip,rk3368-dw-mshc - # for Rockchip RK3399 - rockchip,rk3399-dw-mshc - # for Rockchip RV1108
I find these comments redundant, so I'm fine with the change. But please state why you are removing them in the commit msg. Acked-by: Rob Herring <robh@kernel.org>
+ - rockchip,rk3568-dw-mshc
- rockchip,rv1108-dw-mshc
- const: rockchip,rk3288-dw-mshc
--
2.17.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel