# Re: \[PATCH v3 3/3\] gpio: xilinx: Utilize generic bitmap\_get\_value and \_set\_value

- From: Syed Nayyar Waris \<hidden\>
- Date: 2021-04-02 10:07:41 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2021/04/6325165
- Thread: https://ratatoskr.run/linux-arch/2021/03/6290883/t.md

```text
On Mon, Mar 29, 2021 at 8:54 PM Andy Shevchenko
[ref] wrote:
>
> On Sat, Mar 06, 2021 at 07:36:30PM +0530, Syed Nayyar Waris wrote:
> > This patch reimplements the xgpio_set_multiple() function in
> > drivers/gpio/gpio-xilinx.c to use the new generic functions:
> > bitmap_get_value() and bitmap_set_value(). The code is now simpler
> > to read and understand. Moreover, instead of looping for each bit
> > in xgpio_set_multiple() function, now we can check each channel at
> > a time and save cycles.
>
> ...
>
> > +     u32 *const state = chip->gpio_state;
>
> Looking at this... What's the point of the const here?
>
> Am I right that this tells: pointer is a const, while the data underneath
> can be modified?

Yes you are right and the data underneath can be modified.
I have removed the 'const' in v4

>
> > +     unsigned int *const width = chip->gpio_width;
>
> Ditto.
>
> Putting const:s here and there for sake of the const is not good practice.
> It makes code harder to read.

Okay.

>
> --
> With Best Regards,
> Andy Shevchenko
>
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
```
