# Re: \[PATCH V8 2/8\] cpufreq: mediatek: Enable clock and regulator

- From: andrew-sh.cheng \<hidden\>
- Date: 2021-03-31 05:24:04 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2021/03/8805629
- Thread: https://ratatoskr.run/linux-arm-kernel/2021/03/8805351/t.md

```text
On Tue, 2021-03-30 at 10:06 +0530, Viresh Kumar wrote:
> On 23-03-21, 19:33, Andrew-sh.Cheng wrote:
> > From: "Andrew-sh.Cheng" <redacted>
> > 
> > Need to enable regulator,
> > so that the max/min requested value will be recorded
> > even it is not applied right away.
> > 
> > Intermediate clock is not always enabled by ccf in different projects,
> > so cpufreq should enable it by itself.
> > 
> > Signed-off-by: Andrew-sh.Cheng <redacted>
> > ---
> >  drivers/cpufreq/mediatek-cpufreq.c | 33 +++++++++++++++++++++++++++++----
> >  1 file changed, 29 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> > index f2e491b25b07..432368707ea6 100644
> > --- a/drivers/cpufreq/mediatek-cpufreq.c
> > +++ b/drivers/cpufreq/mediatek-cpufreq.c
> > @@ -350,6 +350,11 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
> >  		ret = PTR_ERR(proc_reg);
> >  		goto out_free_resources;
> >  	}
> > +	ret = regulator_enable(proc_reg);
> > +	if (ret) {
> > +		pr_warn("enable vproc for cpu%d fail\n", cpu);
> > +		goto out_free_resources;
> > +	}
> 
> Regulators are enabled by OPP core as well now, you sure this is
> required ?
> 
Hi Viresh,
Yes.
As you mentioned, it will be enable by OPP core.

Per discuss with hotplug owner and regulator owner,
they suggest that "users should not suppose other module, will enable
regulators for them".
They suggest to add enable_regulator here.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
```