[xlnx:xlnx_rebase_v5.4 935/1700] drivers/usb/dwc3/core.h:1459:6: warning: no previous prototype for 'dwc3_mask_phy_reset'

Hi Piyush,

FYI, the error/warning still remains.

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head:   49bdb4e70d2001f3a5bf0bf5e990cca4a85210f4
commit: 128feece434d1c02d2dfac7e4103b2c73b6afb27 [935/1700] usb: dwc3: Add support for masking phy reset signal
config: c6x-randconfig-r006-20210303 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/Xilinx/linux-xlnx/commit/128feece434d1c02d2dfac7e4103b2c73b6afb27
        git remote add xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xlnx xlnx_rebase_v5.4
        git checkout 128feece434d1c02d2dfac7e4103b2c73b6afb27
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

   In file included from drivers/usb/dwc3/core.c:36:
   drivers/usb/dwc3/core.h:1451:6: warning: no previous prototype for 'dwc3_simple_wakeup_capable' [-Wmissing-prototypes]
    1451 | void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1453:6: warning: no previous prototype for 'dwc3_set_simple_data' [-Wmissing-prototypes]
    1453 | void dwc3_set_simple_data(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1455:6: warning: no previous prototype for 'dwc3_simple_check_quirks' [-Wmissing-prototypes]
    1455 | void dwc3_simple_check_quirks(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1457:5: warning: no previous prototype for 'dwc3_set_usb_core_power' [-Wmissing-prototypes]
    1457 | int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on)
         |     ^~~~~~~~~~~~~~~~~~~~~~~

quoted

drivers/usb/dwc3/core.h:1459:6: warning: no previous prototype for 'dwc3_mask_phy_reset' [-Wmissing-prototypes]

    1459 | void dwc3_mask_phy_reset(struct device *dev, bool mask)
         |      ^~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.c:386:6: warning: no previous prototype for 'dwc3_free_event_buffers' [-Wmissing-prototypes]
     386 | void dwc3_free_event_buffers(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.c:403:5: warning: no previous prototype for 'dwc3_alloc_event_buffers' [-Wmissing-prototypes]
     403 | int dwc3_alloc_event_buffers(struct dwc3 *dwc, unsigned length)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/usb/dwc3/core.c:36:
   drivers/usb/dwc3/core.h: In function 'dwc3_set_usb_core_power':
   drivers/usb/dwc3/core.h:1458:1: warning: control reaches end of non-void function [-Wreturn-type]
    1458 | { ; }
         | ^
--
   In file included from drivers/usb/dwc3/host.c:12:
   include/linux/usb/xhci_pdriver.h:22:6: warning: no previous prototype for 'dwc3_host_wakeup_capable' [-Wmissing-prototypes]
      22 | void dwc3_host_wakeup_capable(struct device *dev, bool wakeup)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/usb/dwc3/host.c:14:
   drivers/usb/dwc3/core.h:1451:6: warning: no previous prototype for 'dwc3_simple_wakeup_capable' [-Wmissing-prototypes]
    1451 | void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1453:6: warning: no previous prototype for 'dwc3_set_simple_data' [-Wmissing-prototypes]
    1453 | void dwc3_set_simple_data(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1455:6: warning: no previous prototype for 'dwc3_simple_check_quirks' [-Wmissing-prototypes]
    1455 | void dwc3_simple_check_quirks(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1457:5: warning: no previous prototype for 'dwc3_set_usb_core_power' [-Wmissing-prototypes]
    1457 | int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on)
         |     ^~~~~~~~~~~~~~~~~~~~~~~

quoted

drivers/usb/dwc3/core.h:1459:6: warning: no previous prototype for 'dwc3_mask_phy_reset' [-Wmissing-prototypes]

    1459 | void dwc3_mask_phy_reset(struct device *dev, bool mask)
         |      ^~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/host.c:16:6: error: redefinition of 'dwc3_host_wakeup_capable'
      16 | void dwc3_host_wakeup_capable(struct device *dev, bool wakeup)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/usb/dwc3/host.c:12:
   include/linux/usb/xhci_pdriver.h:22:6: note: previous definition of 'dwc3_host_wakeup_capable' was here
      22 | void dwc3_host_wakeup_capable(struct device *dev, bool wakeup)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/usb/dwc3/host.c:14:
   drivers/usb/dwc3/core.h: In function 'dwc3_set_usb_core_power':
   drivers/usb/dwc3/core.h:1458:1: warning: control reaches end of non-void function [-Wreturn-type]
    1458 | { ; }
         | ^
--
   In file included from drivers/usb/dwc3/debug.h:14,
                    from drivers/usb/dwc3/gadget.c:25:
   drivers/usb/dwc3/core.h:1451:6: warning: no previous prototype for 'dwc3_simple_wakeup_capable' [-Wmissing-prototypes]
    1451 | void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1453:6: warning: no previous prototype for 'dwc3_set_simple_data' [-Wmissing-prototypes]
    1453 | void dwc3_set_simple_data(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1455:6: warning: no previous prototype for 'dwc3_simple_check_quirks' [-Wmissing-prototypes]
    1455 | void dwc3_simple_check_quirks(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1457:5: warning: no previous prototype for 'dwc3_set_usb_core_power' [-Wmissing-prototypes]
    1457 | int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on)
         |     ^~~~~~~~~~~~~~~~~~~~~~~

quoted

drivers/usb/dwc3/core.h:1459:6: warning: no previous prototype for 'dwc3_mask_phy_reset' [-Wmissing-prototypes]

    1459 | void dwc3_mask_phy_reset(struct device *dev, bool mask)
         |      ^~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h: In function 'dwc3_set_usb_core_power':
   drivers/usb/dwc3/core.h:1458:1: warning: control reaches end of non-void function [-Wreturn-type]
    1458 | { ; }
         | ^


vim +/dwc3_mask_phy_reset +1459 drivers/usb/dwc3/core.h

  1440	
  1441	#if IS_ENABLED(CONFIG_USB_DWC3_OF_SIMPLE)
  1442	int dwc3_enable_hw_coherency(struct device *dev);
  1443	void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup);
  1444	void dwc3_set_simple_data(struct dwc3 *dwc);
  1445	void dwc3_simple_check_quirks(struct dwc3 *dwc);
  1446	int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on);
  1447	void dwc3_mask_phy_reset(struct device *dev, bool mask);
  1448	#else
  1449	static inline int dwc3_enable_hw_coherency(struct device *dev)
  1450	{ return 1; }
  1451	void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup)
  1452	{ ; }
  1453	void dwc3_set_simple_data(struct dwc3 *dwc)
  1454	{ ; }
  1455	void dwc3_simple_check_quirks(struct dwc3 *dwc)
  1456	{ ; }
  1457	int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on)
  1458	{ ; }

1459	void dwc3_mask_phy_reset(struct device *dev, bool mask)

  1460	{ ; }
  1461	#endif
  1462	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org