[PATCH] clk: imx: reference preceded by free

Subsystems: common clk framework, nxp i.mx clock drivers, the rest

STALE1941d

5 messages, 3 authors, 2021-04-08 · open the first message on its own page

[PATCH] clk: imx: reference preceded by free

From: Jian Dong <hidden>
Date: 2021-03-23 03:12:37

From: Jian Dong <redacted>

 when register failed, clk will be freed, it will generate dangling pointer
 problem in later reference. it should return directly.

Signed-off-by: Jian Dong <redacted>
---
 drivers/clk/imx/clk-lpcg-scu.c | 1 +
 drivers/clk/imx/clk-scu.c      | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/clk/imx/clk-lpcg-scu.c b/drivers/clk/imx/clk-lpcg-scu.c
index 77be763..dd5abd0 100644
--- a/drivers/clk/imx/clk-lpcg-scu.c
+++ b/drivers/clk/imx/clk-lpcg-scu.c

@@ -114,6 +114,7 @@ struct clk_hw *__imx_clk_lpcg_scu(struct device *dev, const char *name,
 	if (ret) {
 		kfree(clk);
 		hw = ERR_PTR(ret);
+		return hw;
 	}
 
 	if (dev)

diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
index 1f5518b7..f89b4da 100644
--- a/drivers/clk/imx/clk-scu.c
+++ b/drivers/clk/imx/clk-scu.c

@@ -426,6 +426,7 @@ struct clk_hw *__imx_clk_scu(struct device *dev, const char *name,
 	if (ret) {
 		kfree(clk);
 		hw = ERR_PTR(ret);
+		return hw;
 	}
 
 	if (dev)

-- 
1.9.1



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] clk: imx: reference preceded by free

From: Abel Vesa <hidden>
Date: 2021-03-30 09:18:00

On 21-03-23 11:10:34, Jian Dong wrote:

From: Jian Dong <redacted>

 when register failed, clk will be freed, it will generate dangling pointer
 problem in later reference. it should return directly.

Signed-off-by: Jian Dong <redacted>

Applied, thanks.

quoted hunk

---
 drivers/clk/imx/clk-lpcg-scu.c | 1 +
 drivers/clk/imx/clk-scu.c      | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/clk/imx/clk-lpcg-scu.c b/drivers/clk/imx/clk-lpcg-scu.c
index 77be763..dd5abd0 100644
--- a/drivers/clk/imx/clk-lpcg-scu.c
+++ b/drivers/clk/imx/clk-lpcg-scu.c

@@ -114,6 +114,7 @@ struct clk_hw *__imx_clk_lpcg_scu(struct device *dev, const char *name,
 	if (ret) {
 		kfree(clk);
 		hw = ERR_PTR(ret);
+		return hw;
 	}
 
 	if (dev)

diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
index 1f5518b7..f89b4da 100644
--- a/drivers/clk/imx/clk-scu.c
+++ b/drivers/clk/imx/clk-scu.c

@@ -426,6 +426,7 @@ struct clk_hw *__imx_clk_scu(struct device *dev, const char *name,
 	if (ret) {
 		kfree(clk);
 		hw = ERR_PTR(ret);
+		return hw;
 	}
 
 	if (dev)

-- 
1.9.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] clk: imx: reference preceded by free

From: Stephen Boyd <sboyd@kernel.org>
Date: 2021-03-31 02:17:42

Quoting Jian Dong (2021-03-22 20:10:34)

From: Jian Dong <redacted>

 when register failed, clk will be freed, it will generate dangling pointer
 problem in later reference. it should return directly.

Signed-off-by: Jian Dong <redacted>
---

Any Fixes tag?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] clk: imx: reference preceded by free

From: Jian Dong <hidden>
Date: 2021-04-08 01:54:16

On Tue, 30 Mar 2021 19:16:48 -0700
Stephen Boyd [off-list ref] wrote:

Quoting Jian Dong (2021-03-22 20:10:34)

quoted

From: Jian Dong <redacted>

 when register failed, clk will be freed, it will generate dangling
pointer problem in later reference. it should return directly.

Signed-off-by: Jian Dong <redacted>
---

Any Fixes tag?

Sorry for late, I'm unfamiliar with tag rule.

For this patch include two files commit 2f77296d3 and fe37b482
maybe likes:

Fixes: 2f77296d3	(clk: imx: add lpcg clock support)
Fixes: fe37b482		(clk: imx: add scu clock common part)

and I noticed this patch has been merged, do I need RESEND again with
tags like above?

Thank you


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] clk: imx: reference preceded by free

From: Stephen Boyd <sboyd@kernel.org>
Date: 2021-04-08 07:41:22

Quoting Jian Dong (2021-04-07 18:53:12)

On Tue, 30 Mar 2021 19:16:48 -0700
Stephen Boyd [off-list ref] wrote:

quoted

Quoting Jian Dong (2021-03-22 20:10:34)

quoted

From: Jian Dong <redacted>

 when register failed, clk will be freed, it will generate dangling
pointer problem in later reference. it should return directly.

Signed-off-by: Jian Dong <redacted>
---

Any Fixes tag?

Sorry for late, I'm unfamiliar with tag rule.

For this patch include two files commit 2f77296d3 and fe37b482
maybe likes:

Fixes: 2f77296d3        (clk: imx: add lpcg clock support)
Fixes: fe37b482         (clk: imx: add scu clock common part)

and I noticed this patch has been merged, do I need RESEND again with
tags like above?

Looks like Abel already picked it up so no need to resend.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel