[PATCH] gpu: drm: mediatek: delete redundant printing of return value

Subsystems: drm drivers, drm drivers for mediatek, the rest

STALE1966d

2 messages, 2 authors, 2021-03-14 · open the first message on its own page

[PATCH] gpu: drm: mediatek: delete redundant printing of return value

From: Wang Qing <hidden>
Date: 2021-03-13 07:49:10 

platform_get_irq() has already checked and printed the return value, 
the printing here is nothing special, it is not necessary at all.

Signed-off-by: Wang Qing <redacted>
---
 drivers/gpu/drm/mediatek/mtk_dpi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index b05f900..0ac4962
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -751,10 +751,8 @@ static int mtk_dpi_probe(struct platform_device *pdev)
 	}
 
 	dpi->irq = platform_get_irq(pdev, 0);
-	if (dpi->irq <= 0) {
-		dev_err(dev, "Failed to get irq: %d\n", dpi->irq);
+	if (dpi->irq <= 0)
 		return -EINVAL;
-	}
 
 	ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0,
 					  NULL, &dpi->next_bridge);
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] gpu: drm: mediatek: delete redundant printing of return value

From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date: 2021-03-14 01:43:45 

Hi, Wang:

Wang Qing [off-list ref] 於 2021年3月13日 週六 下午3:48寫道：
platform_get_irq() has already checked and printed the return value,
the printing here is nothing special, it is not necessary at all.
Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.
quoted hunk
Signed-off-by: Wang Qing <redacted>
---
 drivers/gpu/drm/mediatek/mtk_dpi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index b05f900..0ac4962
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -751,10 +751,8 @@ static int mtk_dpi_probe(struct platform_device *pdev)
        }

        dpi->irq = platform_get_irq(pdev, 0);
-       if (dpi->irq <= 0) {
-               dev_err(dev, "Failed to get irq: %d\n", dpi->irq);
+       if (dpi->irq <= 0)
                return -EINVAL;
-       }

        ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0,
                                          NULL, &dpi->next_bridge);
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help