In RGMII mode, the REG_GSWCK_EN bit of CORE_TRGMII_GSW_CLK_CG gets
set three times in a row. In TRGMII mode, two times. Simplify the code
and only set it once for both modes.
Signed-off-by: Ilya Lipnitskiy <redacted>
---
drivers/net/dsa/mt7530.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
3f9ef7785a9c ("MIPS: ralink: manage low reset lines") made it so mt7530
actually resets the switch on platforms such as mt7621 (where bit 2 is
the reset line for the switch). That exposed an issue where the switch
would not function properly in TRGMII mode after a reset.
Reconfigure core clock in TRGMII mode to fix the issue.
Also, disable both core and TRGMII Tx clocks prior to reconfiguring.
Previously, only the core clock was disabled, but not TRGMII Tx clock.
Tested on Ubiquity ER-X (MT7621) with TRGMII mode enabled.
Signed-off-by: Ilya Lipnitskiy <redacted>
---
drivers/net/dsa/mt7530.c | 44 ++++++++++++++++++++--------------------
1 file changed, 22 insertions(+), 22 deletions(-)
@@ -435,30 +435,30 @@ mt7530_pad_clk_setup(struct dsa_switch *ds, phy_interface_t interface)mt7530_write(priv,MT7530_TRGMII_TD_ODT(i),TD_DM_DRVP(8)|TD_DM_DRVN(8));-/* Setup core clock for MT7530 */-if(!trgint){-/* Disable MT7530 core clock */-core_clear(priv,CORE_TRGMII_GSW_CLK_CG,REG_GSWCK_EN);--/* Disable PLL, since phy_device has not yet been created-*providedforphy_[read,write]_mmd_indirectiscalled,we-*provideourowncore_write_mmd_indirecttocompletethis-*function.-*/-core_write(priv,CORE_GSWPLL_GRP1,0);--/* Set core clock into 500Mhz */-core_write(priv,CORE_GSWPLL_GRP2,-RG_GSWPLL_POSDIV_500M(1)|-RG_GSWPLL_FBKDIV_500M(25));+/* Since phy_device has not yet been created and+*phy_[read,write]_mmd_indirectisnotavailable,weprovideourown+*core_write_mmd_indirectwithcore_{clear,write,set}wrappersto+*completethisfunction.+*/-/* Enable PLL */-core_write(priv,CORE_GSWPLL_GRP1,-RG_GSWPLL_EN_PRE|-RG_GSWPLL_POSDIV_200M(2)|-RG_GSWPLL_FBKDIV_200M(32));+/* Disable MT7530 core and TRGMII Tx clocks */+core_clear(priv,CORE_TRGMII_GSW_CLK_CG,+REG_GSWCK_EN|REG_TRGMIICK_EN);-}+/* Setup core clock for MT7530 */+/* Disable PLL */+core_write(priv,CORE_GSWPLL_GRP1,0);++/* Set core clock into 500Mhz */+core_write(priv,CORE_GSWPLL_GRP2,+RG_GSWPLL_POSDIV_500M(1)|+RG_GSWPLL_FBKDIV_500M(25));++/* Enable PLL */+core_write(priv,CORE_GSWPLL_GRP1,+RG_GSWPLL_EN_PRE|+RG_GSWPLL_POSDIV_200M(2)|+RG_GSWPLL_FBKDIV_200M(32));/* Setup the MT7530 TRGMII Tx Clock */core_write(priv,CORE_PLL_GROUP5,RG_LCDDS_PCW_NCPO1(ncpo1));
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Vladimir Oltean <olteanv@gmail.com> Date: 2021-03-10 23:11:02
Hello Ilya,
On Wed, Mar 10, 2021 at 01:14:20PM -0800, Ilya Lipnitskiy wrote:
3f9ef7785a9c ("MIPS: ralink: manage low reset lines") made it so mt7530
actually resets the switch on platforms such as mt7621 (where bit 2 is
the reset line for the switch). That exposed an issue where the switch
would not function properly in TRGMII mode after a reset.
Reconfigure core clock in TRGMII mode to fix the issue.
Also, disable both core and TRGMII Tx clocks prior to reconfiguring.
Previously, only the core clock was disabled, but not TRGMII Tx clock.
Tested on Ubiquity ER-X (MT7621) with TRGMII mode enabled.
Signed-off-by: Ilya Lipnitskiy <redacted>
---
For the networking subsystem there are two git trees, "net" for bugfixes
and "net-next" for new features, and we specify the target tree using
git send-email --subject-prefix="PATCH net-next".
I assume you would like the v5.12 kernel to actually be functional on
the Ubiquiti ER-X switch, so I would recommend keeping this patch
minimal and splitting it out from the current series, and targeting it
towards the "net" tree, which will eventually get merged into one of the
v5.12 rc's and then into the final version. The other patches won't go
into v5.12 but into v5.13, hence the "next" name.
Also add these lines in your .gitconfig:
[core]
abbrev = 12
[pretty]
fixes = Fixes: %h (\"%s\")
and run:
git show 3f9ef7785a9c --pretty=fixes
Fixes: 3f9ef7785a9c ("MIPS: ralink: manage low reset lines")
and paste that "Fixes:" line in the commit message, right above your
Signed-off-by: tag.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Vladimir,
On Wed, Mar 10, 2021 at 3:10 PM Vladimir Oltean [off-list ref] wrote:
Hello Ilya,
On Wed, Mar 10, 2021 at 01:14:20PM -0800, Ilya Lipnitskiy wrote:
quoted
3f9ef7785a9c ("MIPS: ralink: manage low reset lines") made it so mt7530
actually resets the switch on platforms such as mt7621 (where bit 2 is
the reset line for the switch). That exposed an issue where the switch
would not function properly in TRGMII mode after a reset.
Reconfigure core clock in TRGMII mode to fix the issue.
Also, disable both core and TRGMII Tx clocks prior to reconfiguring.
Previously, only the core clock was disabled, but not TRGMII Tx clock.
Tested on Ubiquity ER-X (MT7621) with TRGMII mode enabled.
Signed-off-by: Ilya Lipnitskiy <redacted>
---
For the networking subsystem there are two git trees, "net" for bugfixes
and "net-next" for new features, and we specify the target tree using
git send-email --subject-prefix="PATCH net-next".
I assume you would like the v5.12 kernel to actually be functional on
the Ubiquiti ER-X switch, so I would recommend keeping this patch
minimal and splitting it out from the current series, and targeting it
towards the "net" tree, which will eventually get merged into one of the
v5.12 rc's and then into the final version. The other patches won't go
into v5.12 but into v5.13, hence the "next" name.
I think I knew this, but didn't think it through. Thanks for your
guidance. I have submitted a single patch to "net" and that same patch
and two more to "net-next" - hopefully that looks better, but I'm sure
I have more to learn still.
Also add these lines in your .gitconfig:
[core]
abbrev = 12
[pretty]
fixes = Fixes: %h (\"%s\")
and run:
git show 3f9ef7785a9c --pretty=fixes
Fixes: 3f9ef7785a9c ("MIPS: ralink: manage low reset lines")
and paste that "Fixes:" line in the commit message, right above your
Signed-off-by: tag.
Hi Vladimir,
On Wed, Mar 10, 2021 at 3:10 PM Vladimir Oltean [off-list ref] wrote:
Hello Ilya,
On Wed, Mar 10, 2021 at 01:14:20PM -0800, Ilya Lipnitskiy wrote:
quoted
3f9ef7785a9c ("MIPS: ralink: manage low reset lines") made it so mt7530
actually resets the switch on platforms such as mt7621 (where bit 2 is
the reset line for the switch). That exposed an issue where the switch
would not function properly in TRGMII mode after a reset.
Reconfigure core clock in TRGMII mode to fix the issue.
Also, disable both core and TRGMII Tx clocks prior to reconfiguring.
Previously, only the core clock was disabled, but not TRGMII Tx clock.
Tested on Ubiquity ER-X (MT7621) with TRGMII mode enabled.
Signed-off-by: Ilya Lipnitskiy <redacted>
---
For the networking subsystem there are two git trees, "net" for bugfixes
and "net-next" for new features, and we specify the target tree using
git send-email --subject-prefix="PATCH net-next".
I assume you would like the v5.12 kernel to actually be functional on
the Ubiquiti ER-X switch, so I would recommend keeping this patch
minimal and splitting it out from the current series, and targeting it
towards the "net" tree, which will eventually get merged into one of the
v5.12 rc's and then into the final version. The other patches won't go
into v5.12 but into v5.13, hence the "next" name.
Also add these lines in your .gitconfig:
[core]
abbrev = 12
[pretty]
fixes = Fixes: %h (\"%s\")
and run:
git show 3f9ef7785a9c --pretty=fixes
Fixes: 3f9ef7785a9c ("MIPS: ralink: manage low reset lines")
and paste that "Fixes:" line in the commit message, right above your
Signed-off-by: tag.
Hi Vladimir,
On Wed, Mar 10, 2021 at 3:10 PM Vladimir Oltean [off-list ref] wrote:
quoted
Hello Ilya,
On Wed, Mar 10, 2021 at 01:14:20PM -0800, Ilya Lipnitskiy wrote:
quoted
3f9ef7785a9c ("MIPS: ralink: manage low reset lines") made it so mt7530
actually resets the switch on platforms such as mt7621 (where bit 2 is
the reset line for the switch). That exposed an issue where the switch
would not function properly in TRGMII mode after a reset.
Reconfigure core clock in TRGMII mode to fix the issue.
Also, disable both core and TRGMII Tx clocks prior to reconfiguring.
Previously, only the core clock was disabled, but not TRGMII Tx clock.
Tested on Ubiquity ER-X (MT7621) with TRGMII mode enabled.
Signed-off-by: Ilya Lipnitskiy <redacted>
---
For the networking subsystem there are two git trees, "net" for bugfixes
and "net-next" for new features, and we specify the target tree using
git send-email --subject-prefix="PATCH net-next".
I assume you would like the v5.12 kernel to actually be functional on
the Ubiquiti ER-X switch, so I would recommend keeping this patch
minimal and splitting it out from the current series, and targeting it
towards the "net" tree, which will eventually get merged into one of the
v5.12 rc's and then into the final version. The other patches won't go
into v5.12 but into v5.13, hence the "next" name.
That looks like a mistake on the maintainer side, I do not believe that
patch should be Superseded since you just submitted it.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Florian,
On Wed, Mar 10, 2021 at 7:20 PM Florian Fainelli [off-list ref] wrote:
On 3/10/2021 7:17 PM, Ilya Lipnitskiy wrote:
quoted
Hi Vladimir,
On Wed, Mar 10, 2021 at 3:10 PM Vladimir Oltean [off-list ref] wrote:
quoted
Hello Ilya,
On Wed, Mar 10, 2021 at 01:14:20PM -0800, Ilya Lipnitskiy wrote:
quoted
3f9ef7785a9c ("MIPS: ralink: manage low reset lines") made it so mt7530
actually resets the switch on platforms such as mt7621 (where bit 2 is
the reset line for the switch). That exposed an issue where the switch
would not function properly in TRGMII mode after a reset.
Reconfigure core clock in TRGMII mode to fix the issue.
Also, disable both core and TRGMII Tx clocks prior to reconfiguring.
Previously, only the core clock was disabled, but not TRGMII Tx clock.
Tested on Ubiquity ER-X (MT7621) with TRGMII mode enabled.
Signed-off-by: Ilya Lipnitskiy <redacted>
---
For the networking subsystem there are two git trees, "net" for bugfixes
and "net-next" for new features, and we specify the target tree using
git send-email --subject-prefix="PATCH net-next".
I assume you would like the v5.12 kernel to actually be functional on
the Ubiquiti ER-X switch, so I would recommend keeping this patch
minimal and splitting it out from the current series, and targeting it
towards the "net" tree, which will eventually get merged into one of the
v5.12 rc's and then into the final version. The other patches won't go
into v5.12 but into v5.13, hence the "next" name.
When disabling PLL, there is no need to call core_write_mmd_indirect
directly, use the core_write wrapper instead like the rest of the code
in the function does. This change helps with consistency and
readability.
Signed-off-by: Ilya Lipnitskiy <redacted>
---
drivers/net/dsa/mt7530.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-03-11 17:36:06
On Wed, Mar 10, 2021 at 01:14:19PM -0800, Ilya Lipnitskiy wrote:
quoted hunk
When disabling PLL, there is no need to call core_write_mmd_indirect
directly, use the core_write wrapper instead like the rest of the code
in the function does. This change helps with consistency and
readability.
Signed-off-by: Ilya Lipnitskiy <redacted>
---
drivers/net/dsa/mt7530.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
/* Disable PLL, since phy_device has not yet been created
* provided for phy_[read,write]_mmd_indirect is called, we
* provide our own core_write_mmd_indirect to complete this
* function.
*/
core_write_mmd_indirect(priv,
CORE_GSWPLL_GRP1,
MDIO_MMD_VEND2,
0);
What about the comment? Seems odd to reference
core_write_mmd_indirect() when it is not actually called here after
your change.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel