Hi Daniel,
I stumbled upon a slight oddity in acommit you have contributed.
Please see my comment below.
quoted hunk
commit a7f79f99541eff4e6bcae0014eb08d3019337565
Author: Daniel González Cabanelas [off-list ref]
Date: Wed Jul 15 15:35:14 2020 +0200
power: reset: add driver for LinkStation power off
Some Buffalo LinkStations perform the power off operation, at restart
time, depending on the state of an output pin (LED2/INTn) at the ethernet
PHY. This pin is also used to wake the machine when a WoL packet is
received by the PHY.
The driver is required by the Buffalo LinkStation LS421DE (ARM MVEBU),
and other models. Without it, the board remains forever halted if a
power off command is executed, unless the PSU is disconnected and
connected again.
Add the driver to provide the power off function and also make the WoL
feature to be available.
Signed-off-by: Daniel González Cabanelas [off-list ref]
Signed-off-by: Sebastian Reichel [off-list ref]
...diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile
index 5710ca4695170..c51eceba9ea39 100644
--- a/drivers/power/reset/Makefile
+++ b/drivers/power/reset/Makefile
@@ -10,6 +10,7 @@ obj-$(CONFIG_POWER_RESET_GEMINI_POWEROFF) += gemini-poweroff.o
obj-$(CONFIG_POWER_RESET_GPIO) += gpio-poweroff.o
obj-$(CONFIG_POWER_RESET_GPIO_RESTART) += gpio-restart.o
obj-$(CONFIG_POWER_RESET_HISI) += hisi-reboot.o
+obj-${CONFIG_POWER_RESET_LINKSTATION} += linkstation-poweroff.o
Why are you using curly brackets (ie. shell variable) here instead of
normal parentheses (ie. Make variable)? It might work, but if there is
no special reason for this, we should just be consistent with the rest
of the file.
Cheers
Daniel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
El jue, 18 feb 2021 a las 18:39, Daniel Golle
([off-list ref]) escribió:
Hi Daniel,
I stumbled upon a slight oddity in acommit you have contributed.
Please see my comment below.
quoted
commit a7f79f99541eff4e6bcae0014eb08d3019337565
Author: Daniel González Cabanelas [off-list ref]
Date: Wed Jul 15 15:35:14 2020 +0200
power: reset: add driver for LinkStation power off
Some Buffalo LinkStations perform the power off operation, at restart
time, depending on the state of an output pin (LED2/INTn) at the ethernet
PHY. This pin is also used to wake the machine when a WoL packet is
received by the PHY.
The driver is required by the Buffalo LinkStation LS421DE (ARM MVEBU),
and other models. Without it, the board remains forever halted if a
power off command is executed, unless the PSU is disconnected and
connected again.
Add the driver to provide the power off function and also make the WoL
feature to be available.
Signed-off-by: Daniel González Cabanelas [off-list ref]
Signed-off-by: Sebastian Reichel [off-list ref]
...diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile
index 5710ca4695170..c51eceba9ea39 100644
--- a/drivers/power/reset/Makefile
+++ b/drivers/power/reset/Makefile
@@ -10,6 +10,7 @@ obj-$(CONFIG_POWER_RESET_GEMINI_POWEROFF) += gemini-poweroff.o
obj-$(CONFIG_POWER_RESET_GPIO) += gpio-poweroff.o
obj-$(CONFIG_POWER_RESET_GPIO_RESTART) += gpio-restart.o
obj-$(CONFIG_POWER_RESET_HISI) += hisi-reboot.o
+obj-${CONFIG_POWER_RESET_LINKSTATION} += linkstation-poweroff.o
Why are you using curly brackets (ie. shell variable) here instead of
normal parentheses (ie. Make variable)? It might work, but if there is
no special reason for this, we should just be consistent with the rest
of the file.
Hi Daniel. Indeed there is no reason to use curly brackets.
I have no idea why I commited this small mistake, probably I need to
graduate my glasses. Feel free to send a patch to fix it.
Thank you
Daniel
Cheers
Daniel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Normal parentheses should be used when referring to config variables
in Makefile. Replace the accidentally introduced curly brackets by
regular parentheses.
Fixes: a7f79f99541ef ("power: reset: add driver for LinkStation power off")
Acked-by: Daniel González Cabanelas <redacted>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
drivers/power/reset/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile
index 4f959b6976066..cf3f4d02d8a54 100644
--- a/drivers/power/reset/Makefile
+++ b/drivers/power/reset/Makefile
@@ -11,7 +11,7 @@ obj-$(CONFIG_POWER_RESET_GEMINI_POWEROFF) += gemini-poweroff.o
obj-$(CONFIG_POWER_RESET_GPIO) += gpio-poweroff.o
obj-$(CONFIG_POWER_RESET_GPIO_RESTART) += gpio-restart.o
obj-$(CONFIG_POWER_RESET_HISI) += hisi-reboot.o
-obj-${CONFIG_POWER_RESET_LINKSTATION} += linkstation-poweroff.o
+obj-$(CONFIG_POWER_RESET_LINKSTATION) += linkstation-poweroff.o
obj-$(CONFIG_POWER_RESET_MSM) += msm-poweroff.o
obj-$(CONFIG_POWER_RESET_MT6323) += mt6323-poweroff.o
obj-$(CONFIG_POWER_RESET_OXNAS) += oxnas-restart.o--
2.30.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel