# Re: \[PATCH 15/18\] irqchip/apple-aic: Add support for the Apple Interrupt Controller

- From: Arnd Bergmann \<arnd@kernel.org\>
- Date: 2021-02-08 10:30:52 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2021/02/8804276
- Thread: https://ratatoskr.run/linux-arm-kernel/2021/02/6259165/t.md

```text
On Mon, Feb 8, 2021 at 10:25 AM Marc Zyngier [ref] wrote:
> On Thu, 04 Feb 2021 20:39:48 +0000, Hector Martin [ref] wrote:

> > +{
> > +     return readl(ic->base + reg);
>
> Please consider using the _relaxed accessors, as I don't think any of
> these interacts with memory (apart from IPIs, of course).

MSI interrupts require serializing with DMA, so at the minimum I think there
needs to be something that ensures that DMA from device into memory
has completed before delivering the completion interrupt to a driver. This
may already be implied when the AIC is entered, but this is hard to know
without actual hardware specs.

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
```
