[PATCH] ARM: OMAP2+: add missing call to of_node_put()

Subsystems: arm port, omap hwmod support, omap2+ support, the rest

STALE1979d

2 messages, 2 authors, 2021-03-24 · open the first message on its own page

[PATCH] ARM: OMAP2+: add missing call to of_node_put()

From: Yang Li <hidden>
Date: 2021-02-25 08:55:47

In one of the error paths of the for_each_child_of_node() loop,
add missing call to of_node_put().

Fix the following coccicheck warning:
./arch/arm/mach-omap2/omap_hwmod.c:2132:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 2140.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Yang Li <redacted>
---
 arch/arm/mach-omap2/omap_hwmod.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index 2310cd5..007e91e 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -2137,6 +2137,7 @@ static int of_dev_hwmod_lookup(struct device_node *np,
 		if (res == 0) {
 			*found = fc;
 			*index = i;
+			of_node_put(np0);
 			return 0;
 		}
 	}
-- 
1.8.3.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: OMAP2+: add missing call to of_node_put()

From: Tony Lindgren <tony@atomide.com>
Date: 2021-03-24 11:34:54

* Yang Li [off-list ref] [210225 10:55]:
In one of the error paths of the for_each_child_of_node() loop,
add missing call to of_node_put().
Thanks applying into omap-for-v5.13/soc.

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help