Hardware buffer management has never worked on the Turris Omnia, as the
required MBus window hadn't been reserved. Fix thusly.
Fixes: 018b88eee1a2 ("ARM: dts: turris-omnia: enable HW buffer management")
Signed-off-by: Rui Salvaterra <redacted>
---
arch/arm/boot/dts/armada-385-turris-omnia.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
From: Marek Behún <kabel@kernel.org> Date: 2021-02-17 15:43:34
/o\ How did I manage to miss this?
Please wait a few minutes I am just going to do a fast compile and test.
Marek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi, Marek,
On Wed, 17 Feb 2021 at 15:42, Marek Behún [off-list ref] wrote:
/o\ How did I manage to miss this?
Heh… it happens. :)
Please wait a few minutes I am just going to do a fast compile and test.
No worries. I'm going to cook a backport for OpenWrt.
Cheers,
Rui
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Marek Behún <kabel@kernel.org> Date: 2021-02-17 16:03:20
On Wed, 17 Feb 2021 15:30:38 +0000
Rui Salvaterra [off-list ref] wrote:
Hardware buffer management has never worked on the Turris Omnia, as the
required MBus window hadn't been reserved. Fix thusly.
Fixes: 018b88eee1a2 ("ARM: dts: turris-omnia: enable HW buffer management")
Signed-off-by: Rui Salvaterra <redacted>
From: Marek Behún <kabel@kernel.org> Date: 2021-02-17 16:11:58
Rui, in the future make the subject prefix
[PATCH mvebu-dt]
or
[PATCH mvebu/dt]
so that Gregory knows its for him and for which branch.
Marek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-02-17 16:23:44
On Wed, Feb 17, 2021 at 03:30:38PM +0000, Rui Salvaterra wrote:
Hardware buffer management has never worked on the Turris Omnia, as the
required MBus window hadn't been reserved. Fix thusly.
Hi Rui
I don't know all the details for the MBus Windows...
Can this be set once in armada-385.dtsi ?
Did you check the other dts files. Do any others have the same
problem?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Marek Behún <kabel@kernel.org> Date: 2021-02-17 16:28:33
On Wed, 17 Feb 2021 17:22:17 +0100
Andrew Lunn [off-list ref] wrote:
On Wed, Feb 17, 2021 at 03:30:38PM +0000, Rui Salvaterra wrote:
quoted
Hardware buffer management has never worked on the Turris Omnia, as the
required MBus window hadn't been reserved. Fix thusly.
Hi Rui
I don't know all the details for the MBus Windows...
Can this be set once in armada-385.dtsi ?
Did you check the other dts files. Do any others have the same
problem?
Andrew
armada-38x.dtsi defines only
ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>;
for internal-regs.
It probably depends on how the mbus driver works.
If the mbus driver maps every window defined in ranges, regardless
whether they are used, then we do not want to put all windows in .dtsi
file.
Marek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi, Andrew,
On Wed, 17 Feb 2021 at 16:22, Andrew Lunn [off-list ref] wrote:
Hi Rui
I don't know all the details for the MBus Windows...
Neither do I, I just followed the examples in other device trees
(namely armada-385-linksys.dtsi). I wanted to get hardware buffer
management working on my Omnia, in OpenWrt, so I started digging. :)
Can this be set once in armada-385.dtsi ?
If all SoCs support it, I don't see why not. However, I have to defer
to someone with experience on these systems.
Did you check the other dts files. Do any others have the same
problem?
I did a cursory grep, yes. I see a lot of .dts files with the correct
declaration, so probably aren't that many missing (if any at all,
anymore).
Thanks,
Rui
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Klaus Kudielka <hidden> Date: 2021-03-15 18:09:23
On 17.02.21 16:30, Rui Salvaterra wrote:
Hardware buffer management has never worked on the Turris Omnia, as the
required MBus window hadn't been reserved. Fix thusly.
Fixes: 018b88eee1a2 ("ARM: dts: turris-omnia: enable HW buffer management")
Signed-off-by: Rui Salvaterra <redacted>
Tested-by: Klaus Kudielka <redacted>
(Without this patch, I get a bunch of error messages during 5.11 boot)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hardware buffer management has never worked on the Turris Omnia, as the
required MBus window hadn't been reserved. Fix thusly.
Fixes: 018b88eee1a2 ("ARM: dts: turris-omnia: enable HW buffer management")
Signed-off-by: Rui Salvaterra <redacted>