Re: [PATCH v2 5/7] drm/msm: Add dependency on io-pgtable-arm format module

3 messages, 2 authors, 2021-01-19 · open the first message on its own page

Re: [PATCH v2 5/7] drm/msm: Add dependency on io-pgtable-arm format module

From: Rob Clark <hidden>
Date: 2021-01-18 21:16:29

On Mon, Dec 21, 2020 at 4:44 PM Isaac J. Manjarres
[off-list ref] wrote:
The MSM DRM driver depends on the availability of the ARM LPAE io-pgtable
format code to work properly. In preparation for having the io-pgtable
formats as modules, add a "pre" dependency with MODULE_SOFTDEP() to
ensure that the io-pgtable-arm format module is loaded before loading
the MSM DRM driver module.

Signed-off-by: Isaac J. Manjarres <redacted>
Thanks, I've queued this up locally

BR,
-R
quoted hunk
---
 drivers/gpu/drm/msm/msm_drv.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 535a026..8be3506 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -1369,3 +1369,4 @@ module_exit(msm_drm_unregister);
 MODULE_AUTHOR("Rob Clark <robdclark@gmail.com");
 MODULE_DESCRIPTION("MSM DRM Driver");
 MODULE_LICENSE("GPL");
+MODULE_SOFTDEP("pre: io-pgtable-arm");
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 5/7] drm/msm: Add dependency on io-pgtable-arm format module

From: Will Deacon <will@kernel.org>
Date: 2021-01-18 21:41:07

On Mon, Jan 18, 2021 at 01:16:03PM -0800, Rob Clark wrote:
On Mon, Dec 21, 2020 at 4:44 PM Isaac J. Manjarres
[off-list ref] wrote:
quoted
The MSM DRM driver depends on the availability of the ARM LPAE io-pgtable
format code to work properly. In preparation for having the io-pgtable
formats as modules, add a "pre" dependency with MODULE_SOFTDEP() to
ensure that the io-pgtable-arm format module is loaded before loading
the MSM DRM driver module.

Signed-off-by: Isaac J. Manjarres <redacted>
Thanks, I've queued this up locally
I don't plan to make the io-pgtable code modular, so please drop this patch.

https://lore.kernel.org/r/20210106123428.GA1798@willie-the-truck

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 5/7] drm/msm: Add dependency on io-pgtable-arm format module

From: Rob Clark <hidden>
Date: 2021-01-19 18:28:55

On Mon, Jan 18, 2021 at 1:39 PM Will Deacon [off-list ref] wrote:
On Mon, Jan 18, 2021 at 01:16:03PM -0800, Rob Clark wrote:
quoted
On Mon, Dec 21, 2020 at 4:44 PM Isaac J. Manjarres
[off-list ref] wrote:
quoted
The MSM DRM driver depends on the availability of the ARM LPAE io-pgtable
format code to work properly. In preparation for having the io-pgtable
formats as modules, add a "pre" dependency with MODULE_SOFTDEP() to
ensure that the io-pgtable-arm format module is loaded before loading
the MSM DRM driver module.

Signed-off-by: Isaac J. Manjarres <redacted>
Thanks, I've queued this up locally
I don't plan to make the io-pgtable code modular, so please drop this patch.

https://lore.kernel.org/r/20210106123428.GA1798@willie-the-truck
Ok, done. Thanks

BR,
-R

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help