[PATCH] arm64: dts: freescale: sl28: correct MMC order

Subsystems: arm/freescale layerscape arm architecture, the rest

STALE2072d

3 messages, 2 authors, 2020-11-30 · open the first message on its own page

[PATCH] arm64: dts: freescale: sl28: correct MMC order

From: Michael Walle <hidden>
Date: 2020-11-24 21:22:05

Commit 342ab37ecaf8 ("arm64: dts: freescale: use fixed index mmcN for
layerscape") hardcoded the order of the MMC devices. This doesn't fit
the sl28 boards, which come with an onboard eMMC. Thus use the more
natural order for the eMMC and SD card. Use /dev/mmcblk0 for the eMMC
and /dev/mmcblk1 for the SD card which is removable by the user.

Please note, that the images for this board already use root=UUID=,
therefore the actual device number doesn't matter for booting.

Signed-off-by: Michael Walle <redacted>
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index fbaecf285d05..6da4a28c4d19 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -18,6 +18,8 @@
 
 	aliases {
 		crypto = &crypto;
+		mmc0 = &esdhc1;
+		mmc1 = &esdhc;
 		serial0 = &duart0;
 		serial1 = &duart1;
 		serial2 = &lpuart1;
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH] arm64: dts: freescale: sl28: correct MMC order

From: "Y.b. Lu" <yangbo.lu@nxp.com>
Date: 2020-11-25 03:04:43

-----Original Message-----
From: Michael Walle <redacted>
Sent: Wednesday, November 25, 2020 5:21 AM
To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
linux-kernel@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <redacted>; Rob
Herring [off-list ref]; Y.b. Lu [off-list ref]; Vladimir
Oltean [off-list ref]; Michael Walle [off-list ref]
Subject: [PATCH] arm64: dts: freescale: sl28: correct MMC order

Commit 342ab37ecaf8 ("arm64: dts: freescale: use fixed index mmcN for
layerscape") hardcoded the order of the MMC devices. This doesn't fit
the sl28 boards, which come with an onboard eMMC. Thus use the more
natural order for the eMMC and SD card. Use /dev/mmcblk0 for the eMMC
and /dev/mmcblk1 for the SD card which is removable by the user.

Please note, that the images for this board already use root=UUID=,
therefore the actual device number doesn't matter for booting.

Signed-off-by: Michael Walle <redacted>
It's ok for me to re-define mmc alias.
Reviewed-by: Yangbo Lu <yangbo.lu@nxp.com>
quoted hunk
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index fbaecf285d05..6da4a28c4d19 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -18,6 +18,8 @@

 	aliases {
 		crypto = &crypto;
+		mmc0 = &esdhc1;
+		mmc1 = &esdhc;
 		serial0 = &duart0;
 		serial1 = &duart1;
 		serial2 = &lpuart1;
--
2.20.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: freescale: sl28: correct MMC order

From: Michael Walle <hidden>
Date: 2020-11-30 15:19:59

Am 2020-11-24 22:21, schrieb Michael Walle:
quoted hunk
Commit 342ab37ecaf8 ("arm64: dts: freescale: use fixed index mmcN for
layerscape") hardcoded the order of the MMC devices. This doesn't fit
the sl28 boards, which come with an onboard eMMC. Thus use the more
natural order for the eMMC and SD card. Use /dev/mmcblk0 for the eMMC
and /dev/mmcblk1 for the SD card which is removable by the user.

Please note, that the images for this board already use root=UUID=,
therefore the actual device number doesn't matter for booting.

Signed-off-by: Michael Walle <redacted>
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git
a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index fbaecf285d05..6da4a28c4d19 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -18,6 +18,8 @@

 	aliases {
 		crypto = &crypto;
+		mmc0 = &esdhc1;
+		mmc1 = &esdhc;
 		serial0 = &duart0;
 		serial1 = &duart1;
 		serial2 = &lpuart1;
This will be superfluous because Vladimirs patch was applied:
https://lore.kernel.org/linux-devicetree/20201130143923.GK4072@dragon/

Thanks!
-michael

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help