[PATCH] [RFC] drm/stm: Prefer faster display pixel clock over slower ones
From: Marek Vasut <marex@denx.de>
Date: 2020-09-09 19:00:06
Also in:
dri-devel
Subsystem:
drm drivers, drm drivers and misc gpu patches, the rest · Maintainers:
David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Linus Torvalds
If the delta between requested pixelclock and resulting pixelclock is larger than the delta between requested pixelclock and the next step in available pixelclock (limited to 10% of pixelclock to avoid too much out-of-specification operation), use the faster pixelclock. This fixes the condition where the resulting pixelclock is much slower than the lowest clock rate supported by the display, while the next available pixelclock are just slightly faster than the highest clock rate supported by the display. Using the lower clock rate leads e.g. to subtle artifacts barely visible on the display, like flickering pixels. Using slightly faster clock leads to no such effect. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Alexandre Torgue <redacted> Cc: Benjamin Gaignard <redacted> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Philippe Cornu <redacted> Cc: Vincent Abriou <redacted> Cc: Yannick Fertré <redacted> Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com --- drivers/gpu/drm/stm/ltdc.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 6e28f707092f..07c73079293c 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c@@ -507,6 +507,25 @@ static bool ltdc_crtc_mode_fixup(struct drm_crtc *crtc, { struct ltdc_device *ldev = crtc_to_ltdc(crtc); int rate = mode->clock * 1000; + int rate_min = clk_round_rate(ldev->pixel_clk, rate); + int rate_max = clk_round_rate(ldev->pixel_clk, rate + (rate / 10)); + + /* + * If the delta between requested pixelclock and resulting pixelclock + * is larger than the delta between requested pixelclock and the next + * step in available pixelclock (limited to 10% of pixelclock to avoid + * too much out-of-specification operation), use the faster pixelclock. + * + * This fixes the condition where the resulting pixelclock is much + * slower than the lowest clock rate supported by the display, while + * the next available pixelclock are just slightly faster than the + * highest clock rate supported by the display. Using the lower clock + * rate leads e.g. to subtle artifacts barely visible on the display, + * like flickering pixels. Using slightly faster clock leads to no + * such effect. + */ + if (rate - rate_min > rate_max - rate) + rate = rate_max; if (clk_set_rate(ldev->pixel_clk, rate) < 0) { DRM_ERROR("Cannot set rate (%dHz) for pixel clk\n", rate);
--
2.28.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel