Thread (51 messages) 51 messages, 4 authors, 2020-09-02

Re: [PATCH v3 08/13] mm/debug_vm_pgtable/thp: Use page table depost/withdraw with THP

From: Anshuman Khandual <hidden>
Date: 2020-09-02 03:46:44
Also in: linux-arch, linux-mm, linux-s390, linuxppc-dev


On 09/01/2020 01:21 PM, Christophe Leroy wrote:

Le 01/09/2020 à 09:40, Aneesh Kumar K.V a écrit :
quoted
On 9/1/20 12:20 PM, Christophe Leroy wrote:
quoted

Le 01/09/2020 à 08:25, Aneesh Kumar K.V a écrit :
quoted
On 9/1/20 8:52 AM, Anshuman Khandual wrote:
quoted


There is a checkpatch.pl warning here.

WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7:
Architectures like ppc64 use deposited page table while updating the huge pte

total: 0 errors, 1 warnings, 40 lines checked
I will ignore all these, because they are not really important IMHO.
When doing a git log in a 80 chars terminal window, having wrapping lines is not really convenient. It should be easy to avoid it.
We have been ignoring that for a long time  isn't it?

For example ppc64 checkpatch already had
--max-line-length=90


There was also recent discussion whether 80 character limit is valid any more. But I do keep it restricted to 80 character where ever it is easy/make sense.
Here we are not talking about the code, but the commit log.

As far as I know, the discussions about 80 character lines, 90 lines in powerpc etc ... is for the code.

We still aim at keeping lines not longer than 75 chars in the commit log.
Agreed.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help