DORMANTno replies

[PATCH] irqchip/ti-sci-inta: Fix unsigned expression compared with zero in ti_sci_inta_alloc_parent_irq

From: Ye Bin <hidden>
Date: 2020-08-24 07:45:20
Subsystem: irqchip drivers, texas instruments' system control interface (tisci) protocol driver, the rest · Maintainers: Thomas Gleixner, Nishanth Menon, Tero Kristo, Santosh Shilimkar, Linus Torvalds

Signed-off-by: Ye Bin <redacted>
---
 drivers/irqchip/irq-ti-sci-inta.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
index d4e97605456b..37d09cbdc15c 100644
--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -182,12 +182,13 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom
 	if (vint_id == TI_SCI_RESOURCE_NULL)
 		return ERR_PTR(-EINVAL);
 
-	p_hwirq = ti_sci_inta_xlate_irq(inta, vint_id);
-	if (p_hwirq < 0) {
-		ret = p_hwirq;
+	ret = ti_sci_inta_xlate_irq(inta, vint_id);
+	if (ret < 0) {
 		goto free_vint;
 	}
 
+	p_hwirq = ret;
+
 	vint_desc = kzalloc(sizeof(*vint_desc), GFP_KERNEL);
 	if (!vint_desc) {
 		ret = -ENOMEM;
-- 
2.25.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help