# \[PATCH\] mmc: meson-gx: use wrapper to avoid accessing internal vars - Subsystems: ARM/Amlogic Meson SoC support, MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND SDIO SUBSYSTEM, THE REST - Maintainers: Neil Armstrong, Kevin Hilman, Ulf Hansson, Linus Torvalds - Status: LANDED (e0c29be62cdc ยท 2020-09-07 07:11) - Landed in mainline as e0c29be62cdc on 2020-09-07. - List: linux-arm-kernel - 3 messages, 3 authors - Page: https://ratatoskr.run/linux-arm-kernel/2020/08/6088085/t ## \[PATCH\] mmc: meson-gx: use wrapper to avoid accessing internal vars - From: Wolfram Sang \ - Date: 2020-08-31 10:23:37 - Message: https://ratatoskr.run/linux-arm-kernel/2020/08/6088085.md ```text Signed-off-by: Wolfram Sang --- Only buildtested. Found while analyzing retune-handling in the core. drivers/mmc/host/meson-gx-mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 08a3b1c05acb..a1db8685e30e 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode) val |= ADJUST_ADJ_EN; writel(val, host->regs + host->data->adjust); - if (mmc->doing_retune) + if (mmc_doing_retune(mmc)) dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1; else dly = 0; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ``` ## Re: \[PATCH\] mmc: meson-gx: use wrapper to avoid accessing internal vars - From: Kevin Hilman \ - Date: 2020-08-31 18:35:46 - Message: https://ratatoskr.run/linux-arm-kernel/2020/08/6088700.md ```text Wolfram Sang [ref] writes: > Signed-off-by: Wolfram Sang Reviewed-by: Kevin Hilman > --- > > Only buildtested. Found while analyzing retune-handling in the core. > > drivers/mmc/host/meson-gx-mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c > index 08a3b1c05acb..a1db8685e30e 100644 > --- a/drivers/mmc/host/meson-gx-mmc.c > +++ b/drivers/mmc/host/meson-gx-mmc.c > @@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode) > val |= ADJUST_ADJ_EN; > writel(val, host->regs + host->data->adjust); > > - if (mmc->doing_retune) > + if (mmc_doing_retune(mmc)) > dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1; > else > dly = 0; > -- > 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ``` ## Re: \[PATCH\] mmc: meson-gx: use wrapper to avoid accessing internal vars - From: Ulf Hansson \ - Date: 2020-09-02 09:04:28 - Message: https://ratatoskr.run/linux-arm-kernel/2020/09/6091387.md ```text On Mon, 31 Aug 2020 at 12:23, Wolfram Sang [ref] wrote: > > Signed-off-by: Wolfram Sang Applied for next, thanks! Kind regards Uffe > --- > > Only buildtested. Found while analyzing retune-handling in the core. > > drivers/mmc/host/meson-gx-mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c > index 08a3b1c05acb..a1db8685e30e 100644 > --- a/drivers/mmc/host/meson-gx-mmc.c > +++ b/drivers/mmc/host/meson-gx-mmc.c > @@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode) > val |= ADJUST_ADJ_EN; > writel(val, host->regs + host->data->adjust); > > - if (mmc->doing_retune) > + if (mmc_doing_retune(mmc)) > dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1; > else > dly = 0; > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ```