Thread (4 messages) 4 messages, 3 authors, 2020-08-31

Re: [PATCH 0/8] drivers: phy: Constify static phy_ops structs

From: Joe Perches <joe@perches.com>
Date: 2020-08-23 22:07:51
Also in: linux-arm-msm, linux-usb, lkml
Subsystem: the rest · Maintainer: Linus Torvalds

On Mon, 2020-08-24 at 00:00 +0200, Rikard Falkeborn wrote:
This series constifies all static phy_ops structs in drivers/phy.
Typically the only usage is to pass the address of it to devm_phy_create()
which takes a const pointer. The lone exception is in
drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c where the address of the
structs is assigned to the data-field in of_device_id, which is a const
void pointer.

Making the structs const allows the compiler to put them in read-only
memory.

The patches are all independent of each other, and have been
compile-tested only.
Perhaps add phy_ops to scripts/const_structs.checkpatch too
---
 scripts/const_structs.checkpatch | 1 +
 1 file changed, 1 insertion(+)
diff --git a/scripts/const_structs.checkpatch b/scripts/const_structs.checkpatch
index e9df9cc28a85..cd45cb3c2b04 100644
--- a/scripts/const_structs.checkpatch
+++ b/scripts/const_structs.checkpatch
@@ -39,6 +39,7 @@ nlmsvc_binding
 nvkm_device_chip
 of_device_id
 pci_raw_ops
+phy_ops
 pipe_buf_operations
 platform_hibernation_ops
 platform_suspend_ops


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help