# Re: \[PATCH v7 3/3\] arm64: implement KPROBES\_ON\_FTRACE

- From: Masami Hiramatsu \<mhiramat@kernel.org\>
- Date: 2020-07-24 16:54:54 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2020/07/6049016
- Thread: https://ratatoskr.run/linux-doc/2019/12/5815421/t.md

```text
On Fri, 24 Jul 2020 15:06:11 +0800
Jisheng Zhang [ref] wrote:

> 
> On Tue, 21 Jul 2020 22:24:55 +0900 Masami Hiramatsu wrote:
> 
> > 
> > 
> > Hi Jisheng,
> 
> Hi,
> 
> > 
> > Would you be still working on this series?
> 
> I will rebase the implementation on the latest code, then try to address
> your comments and Mark's comments. I will send out patches in this weekend.
> 
> > 
> > If you are still want to put a probe on func+4, it is OK if you can
> > completely emulate the 1st instruction. (lr save on the stack and
> > change the regs->sp)
> 
> Will check which is the better solution.

Thanks Jisheng!

What I'm considering is the consistency of pre_handler()@addr and 
post_handler()@addr+4. Also, whether the value of regs (and stacks) is
same as the user expected.

Thank you,

-- 
Masami Hiramatsu [ref]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
```