[PATCH] irqchip/stm32: fix return value of stm32_exti_h_set_affinity

Subsystems: irqchip drivers, the rest

STALE2177d

2 messages, 1 author, 2020-09-21 · open the first message on its own page

[PATCH] irqchip/stm32: fix return value of stm32_exti_h_set_affinity

From: Ludovic Barre <hidden>
Date: 2020-06-12 07:29:40

exti hardware point of view, there is no specific action on set_affinity.
So the affinity must be forwarded to parent if there is a
descendent irqchips, otherwise just return IRQ_SET_MASK_OK_DONE.

Signed-off-by: Ludovic Barre <redacted>
---
 drivers/irqchip/irq-stm32-exti.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
index faa8482c8246..1a0a60ee7140 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32-exti.c
@@ -555,7 +555,7 @@ static int stm32_exti_h_set_affinity(struct irq_data *d,
 	if (d->parent_data->chip)
 		return irq_chip_set_affinity_parent(d, dest, force);
 
-	return -EINVAL;
+	return IRQ_SET_MASK_OK_DONE;
 }
 
 static int __maybe_unused stm32_exti_h_suspend(void)
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] irqchip/stm32: fix return value of stm32_exti_h_set_affinity

From: Ludovic BARRE <hidden>
Date: 2020-09-21 09:55:10

Hi Marc

Just a gentleman ping about this patch.
I verified, you could always apply this patch on linux master branch.

Regards
Ludo

Le 6/12/20 à 9:29 AM, Ludovic Barre a écrit :
quoted hunk
exti hardware point of view, there is no specific action on set_affinity.
So the affinity must be forwarded to parent if there is a
descendent irqchips, otherwise just return IRQ_SET_MASK_OK_DONE.

Signed-off-by: Ludovic Barre <redacted>
---
  drivers/irqchip/irq-stm32-exti.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
index faa8482c8246..1a0a60ee7140 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32-exti.c
@@ -555,7 +555,7 @@ static int stm32_exti_h_set_affinity(struct irq_data *d,
  	if (d->parent_data->chip)
  		return irq_chip_set_affinity_parent(d, dest, force);
  
-	return -EINVAL;
+	return IRQ_SET_MASK_OK_DONE;
  }
  
  static int __maybe_unused stm32_exti_h_suspend(void)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help