[PATCH V2] genirq: Check irq_data_get_irq_chip() return value before use
From: Marek Vasut <marex@denx.de>
Date: 2020-05-14 00:26:15
Subsystem:
irq subsystem, the rest · Maintainers:
Thomas Gleixner, Linus Torvalds
The irq_data_get_irq_chip() can return NULL, however it is expected
that this never happens. If a buggy driver leads to a NULL being
returned from irq_data_get_irq_chip(), warn about it.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Linus Walleij <redacted>
Cc: Marc Zyngier <redacted>
Cc: Stephen Boyd <redacted>
Cc: Thomas Gleixner <redacted>
To: linux-arm-kernel@lists.infradead.org
---
V2: - Use WARN_ON_ONCE() and return -ENODEV
- Reword the commit message
---
kernel/irq/manage.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 453a8a0f4804..761911168438 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c@@ -2619,6 +2619,8 @@ int __irq_get_irqchip_state(struct irq_data *data, enum irqchip_irq_state which, do { chip = irq_data_get_irq_chip(data); + if (WARN_ON_ONCE(!chip)) + return -ENODEV; if (chip->irq_get_irqchip_state) break; #ifdef CONFIG_IRQ_DOMAIN_HIERARCHY
@@ -2696,6 +2698,8 @@ int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which, do { chip = irq_data_get_irq_chip(data); + if (WARN_ON_ONCE(!chip)) + return -ENODEV; if (chip->irq_set_irqchip_state) break; #ifdef CONFIG_IRQ_DOMAIN_HIERARCHY
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel