[arm:clearfog 9/10] drivers/pci/pcie/portdrv_core.c:328 pcie_port_device_register() warn: inconsistent indenting
From: kbuild test robot <hidden>
Date: 2020-03-04 03:17:49
Also in:
oe-kbuild-all
tree: git://git.armlinux.org.uk/~rmk/linux-arm.git clearfog
head: 37b5143f7596c85d4503125a420368f21140dcd8
commit: 9796468e9417d3a41882bcdf2d1201ce4b6160c9 [9/10] mvebu/clearfog pcie updates
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>
New smatch warnings:
drivers/pci/pcie/portdrv_core.c:328 pcie_port_device_register() warn: inconsistent indenting
drivers/pci/pcie/aspm.c:579 pcie_aspm_cap_init() warn: inconsistent indenting
Old smatch warnings:
drivers/pci/pcie/portdrv_core.c:341 pcie_port_device_register() warn: inconsistent indenting
vim +328 drivers/pci/pcie/portdrv_core.c
308
309 /**
310 * pcie_port_device_register - register PCI Express port
311 * @dev: PCI Express port to register
312 *
313 * Allocate the port extension structure and register services associated with
314 * the port.
315 */
316 int pcie_port_device_register(struct pci_dev *dev)
317 {
318 int status, capabilities, i, nr_service;
319 int irqs[PCIE_PORT_DEVICE_MAXSERVICES];
320
321 /* Enable PCI Express port device */
322 status = pci_enable_device(dev);
323 if (status)
324 return status;
325
326 /* Get and check PCI Express port services */
327 capabilities = get_port_device_capability(dev);
> 328 dev_info(&dev->dev, "PCIe capabilities: 0x%x\n", capabilities);
329 if (!capabilities)
330 return 0;
331
332 pci_set_master(dev);
333 /*
334 * Initialize service irqs. Don't use service devices that
335 * require interrupts if there is no way to generate them.
336 * However, some drivers may have a polling mode (e.g. pciehp_poll_mode)
337 * that can be used in the absence of irqs. Allow them to determine
338 * if that is to be used.
339 */
340 status = pcie_init_service_irqs(dev, irqs, capabilities);
341 dev_info(&dev->dev, "init_service_irqs: %d\n", status);
342 if (status) {
343 capabilities &= PCIE_PORT_SERVICE_HP;
344 if (!capabilities)
345 goto error_disable;
346 }
347
348 /* Allocate child services if any */
349 status = -ENODEV;
350 nr_service = 0;
351 for (i = 0; i < PCIE_PORT_DEVICE_MAXSERVICES; i++) {
352 int service = 1 << i;
353 if (!(capabilities & service))
354 continue;
355 if (!pcie_device_init(dev, service, irqs[i]))
356 nr_service++;
357 }
358 if (!nr_service)
359 goto error_cleanup_irqs;
360
361 return 0;
362
363 error_cleanup_irqs:
364 pci_free_irq_vectors(dev);
365 error_disable:
366 pci_disable_device(dev);
367 return status;
368 }
369
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel