DORMANTno replies

[RFC PATCH v1 48/50] arch/arm/kernel/process.c: Use get_random_max32() for sigpage_addr()

From: George Spelvin <hidden>
Date: 2020-03-28 16:44:12
Also in: lkml
Subsystem: arm port, the rest · Maintainers: Russell King, Linus Torvalds

Which is faster and less biased than get_random_int() % range

Signed-off-by: George Spelvin <redacted>
Cc: Nathan Lynch <redacted>
Cc: Dmitry Safonov <redacted>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
---
 arch/arm/kernel/process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 46e478fb5ea20..9f2556be33505 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -391,7 +391,7 @@ static unsigned long sigpage_addr(const struct mm_struct *mm,
 
 	slots = ((last - first) >> PAGE_SHIFT) + 1;
 
-	offset = get_random_int() % slots;
+	offset = get_random_max32(slots);
 
 	addr = first + (offset << PAGE_SHIFT);
 
-- 
2.26.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help