[arm:zii 77/96] drivers/net/ethernet/marvell/mvneta.c:3901:39: error: expected ')' before ';' token

From: kbuild test robot <hidden>
Date: 2020-02-13 04:15:27
Also in: oe-kbuild-all

tree:   git://git.armlinux.org.uk/~rmk/linux-arm.git zii
head:   c058559ef54abb83a3fe0029850639917b37affa
commit: 85e3f6162ac8950832aec8bc427fbd9a9cf898b6 [77/96] net: mvneta: use resolved link config in mac_link_up()
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 85e3f6162ac8950832aec8bc427fbd9a9cf898b6
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/marvell/mvneta.c: In function 'mvneta_mac_link_up':
quoted
drivers/net/ethernet/marvell/mvneta.c:3901:39: error: expected ')' before ';' token
      val &= ~(MVNETA_GMAC_FORCE_LINK_DOWN;
                                          ^

vim +3901 drivers/net/ethernet/marvell/mvneta.c

  3888	
  3889	static void mvneta_mac_link_up(struct phylink_config *config,
  3890				       struct phy_device *phy,
  3891				       unsigned int mode, phy_interface_t interface,
  3892				       int speed, int duplex,
  3893				       bool tx_pause, bool rx_pause)
  3894	{
  3895		struct net_device *ndev = to_net_dev(config->dev);
  3896		struct mvneta_port *pp = netdev_priv(ndev);
  3897		u32 val;
  3898	
  3899		if (!phylink_autoneg_inband(mode)) {
  3900			val = mvreg_read(pp, MVNETA_GMAC_AUTONEG_CONFIG);
3901			val &= ~(MVNETA_GMAC_FORCE_LINK_DOWN;
  3902				 MVNETA_GMAC_CONFIG_MII_SPEED |
  3903				 MVNETA_GMAC_CONFIG_GMII_SPEED |
  3904				 MVNETA_GMAC_CONFIG_FLOW_CTRL |
  3905				 MVNETA_GMAC_CONFIG_FULL_DUPLEX);
  3906			val |= MVNETA_GMAC_FORCE_LINK_PASS;
  3907	
  3908			if (speed == SPEED_1000 || speed == SPEED_2500)
  3909				val |= MVNETA_GMAC_CONFIG_GMII_SPEED;
  3910			else if (speed == SPEED_100)
  3911				val |= MVNETA_GMAC_CONFIG_MII_SPEED;
  3912	
  3913			if (duplex == DUPLEX_FULL)
  3914				val |= MVNETA_GMAC_CONFIG_FULL_DUPLEX;
  3915	
  3916			if (tx_pause || rx_pause)
  3917				val |= MVNETA_GMAC_CONFIG_FLOW_CTRL;
  3918	
  3919			mvreg_write(pp, MVNETA_GMAC_AUTONEG_CONFIG, val);
  3920		} else if (interface == PHY_INTERFACE_MODE_SGMII) {
  3921			/* In-band doesn't cover flow control, so we need to handle
  3922			 * that manually.
  3923			 */
  3924			val = mvreg_read(pp, MVNETA_GMAC_AUTONEG_CONFIG);
  3925			val &= ~MVNETA_GMAC_CONFIG_FLOW_CTRL;
  3926	
  3927			if (tx_pause || rx_pause)
  3928				val |= MVNETA_GMAC_CONFIG_FLOW_CTRL;
  3929	
  3930			mvreg_write(pp, MVNETA_GMAC_AUTONEG_CONFIG, val);
  3931		}
  3932	
  3933		mvneta_port_up(pp);
  3934	
  3935		if (phy && pp->eee_enabled) {
  3936			pp->eee_active = phy_init_eee(phy, 0) >= 0;
  3937			mvneta_set_eee(pp, pp->eee_active && pp->tx_lpi_enabled);
  3938		}
  3939	}
  3940	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help