[xlnx:xlnx_rebase_v5.4 129/707] sound/soc/xilinx/xlnx_spdif.c:299:3: error: 'res' undeclared; did you mean 'ret'?

From: kbuild test robot <hidden>
Date: 2020-01-10 09:34:30
Also in: oe-kbuild-all

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head:   1e95d891a328c985e29743b334c8368a76c24b18
commit: 06657e5e0bafb7fad1513f72683c2d1698562dec [129/707] ASoC: xlnx: add SPDIF audio driver
config: x86_64-randconfig-c003-20200109 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
        git checkout 06657e5e0bafb7fad1513f72683c2d1698562dec
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>

All errors (new ones prefixed by >>):

   sound/soc/xilinx/xlnx_spdif.c: In function 'xlnx_spdif_probe':
quoted
sound/soc/xilinx/xlnx_spdif.c:299:3: error: 'res' undeclared (first use in this function); did you mean 'ret'?
      res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
      ^~~
      ret
   sound/soc/xilinx/xlnx_spdif.c:299:3: note: each undeclared identifier is reported only once for each function it appears in

vim +299 sound/soc/xilinx/xlnx_spdif.c

b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  248  
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  249  static int xlnx_spdif_probe(struct platform_device *pdev)
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  250  {
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  251  	int ret;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  252  	struct snd_soc_dai_driver *dai_drv;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  253  	struct spdif_dev_data *ctx;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  254  
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  255  	struct device *dev = &pdev->dev;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  256  	struct device_node *node = dev->of_node;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  257  
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  258  	ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  259  	if (!ctx)
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  260  		return -ENOMEM;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  261  
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  262  	ctx->axi_clk = devm_clk_get(dev, "s_axi_aclk");
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  263  	if (IS_ERR(ctx->axi_clk)) {
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  264  		ret = PTR_ERR(ctx->axi_clk);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  265  		dev_err(dev, "failed to get s_axi_aclk(%d)\n", ret);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  266  		return ret;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  267  	}
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  268  	ret = clk_prepare_enable(ctx->axi_clk);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  269  	if (ret) {
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  270  		dev_err(dev, "failed to enable s_axi_aclk(%d)\n", ret);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  271  		return ret;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  272  	}
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  273  
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  274  	ctx->aud_clk = devm_clk_get(dev, "aud_clk_i");
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  275  	if (IS_ERR(ctx->aud_clk)) {
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  276  		ret = PTR_ERR(ctx->aud_clk);
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  277  		dev_err(dev, "failed to get aud_aclk(%d)\n", ret);
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  278  		goto axi_clk_err;
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  279  	}
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  280  	ret = clk_prepare_enable(ctx->aud_clk);
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  281  	if (ret) {
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  282  		dev_err(dev, "failed to enable aud_aclk(%d)\n", ret);
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  283  		goto axi_clk_err;
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  284  	}
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  285  
cf80aa2c1359f5 YueHaibing                   2019-07-27  286  	ctx->base = devm_platform_ioremap_resource(pdev, 0);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  287  	if (IS_ERR(ctx->base)) {
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  288  		ret = PTR_ERR(ctx->base);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  289  		goto clk_err;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  290  	}
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  291  	ret = of_property_read_u32(node, "xlnx,spdif-mode", &ctx->mode);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  292  	if (ret < 0) {
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  293  		dev_err(dev, "cannot get SPDIF mode\n");
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  294  		goto clk_err;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  295  	}
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  296  	if (ctx->mode) {
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  297  		dai_drv = &xlnx_spdif_tx_dai;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  298  	} else {
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03 @299  		res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  300  		if (!res) {
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  301  			dev_err(dev, "No IRQ resource found\n");
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  302  			ret = -ENODEV;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  303  			goto clk_err;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  304  		}
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  305  		ret = devm_request_irq(dev, res->start,
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  306  				       xlnx_spdifrx_irq_handler,
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  307  				       0, "XLNX_SPDIF_RX", ctx);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  308  		if (ret) {
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  309  			dev_err(dev, "spdif rx irq request failed\n");
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  310  			ret = -ENODEV;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  311  			goto clk_err;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  312  		}
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  313  
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  314  		init_waitqueue_head(&ctx->chsts_q);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  315  		dai_drv = &xlnx_spdif_rx_dai;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  316  	}
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  317  
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  318  	dev_set_drvdata(dev, ctx);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  319  
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  320  	ret = devm_snd_soc_register_component(dev, &xlnx_spdif_component,
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  321  					      dai_drv, 1);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  322  	if (ret) {
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  323  		dev_err(dev, "SPDIF component registration failed\n");
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  324  		goto clk_err;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  325  	}
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  326  
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  327  	writel(XSPDIF_SOFT_RESET_VAL, ctx->base + XSPDIF_SOFT_RESET_REG);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  328  	dev_info(dev, "%s DAI registered\n", dai_drv->name);
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  329  	return 0;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  330  
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  331  clk_err:
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  332  	clk_disable_unprepare(ctx->aud_clk);
06657e5e0bafb7 Maruthi Srinivas Bayyavarapu 2018-11-30  333  axi_clk_err:
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  334  	clk_disable_unprepare(ctx->axi_clk);
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  335  	return ret;
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  336  }
b1d2a4cca20cb8 Maruthi Srinivas Bayyavarapu 2019-01-03  337  

:::::: The code at line 299 was first introduced by commit
:::::: b1d2a4cca20cb84ffe02116fd8d2b91a94d49d5e ASoC: xlnx: add SPDIF audio driver

:::::: TO: Maruthi Srinivas Bayyavarapu [off-list ref]
:::::: CC: Mark Brown [off-list ref]

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help