[PATCH 0/2] add new DRM_DEV_WARN macro

STALE2455d

5 messages, 4 authors, 2019-11-18 · open the first message on its own page

[PATCH 0/2] add new DRM_DEV_WARN macro

From: Wambui Karuga <hidden>
Date: 2019-11-14 13:24:51

This adds a new DRM_DEV_WARN helper macro for warnings log output that include
device pointers. It also includes the use of the DRM_DEV_WARN macro in
drm/rockchip to replace dev_warn.

Wambui Karuga (2):
  drm/print: add DRM_DEV_WARN macro
  drm/rockchip: use DRM_DEV_WARN macro in debug output

 drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++-
 include/drm/drm_print.h              | 9 +++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] add new DRM_DEV_WARN macro

From: Jani Nikula <jani.nikula@linux.intel.com>
Date: 2019-11-15 11:53:02

On Thu, 14 Nov 2019, Wambui Karuga [off-list ref] wrote:
This adds a new DRM_DEV_WARN helper macro for warnings log output that include
device pointers. It also includes the use of the DRM_DEV_WARN macro in
drm/rockchip to replace dev_warn.
I'm trying to solicit new struct drm_device based logging macros, and
starting to convert to those. [1]

BR,
Jani.


[1] http://patchwork.freedesktop.org/patch/msgid/63d1e72b99e9c13ee5b1b362a653ff9c21e19124.1572258936.git.jani.nikula@intel.com



Wambui Karuga (2):
  drm/print: add DRM_DEV_WARN macro
  drm/rockchip: use DRM_DEV_WARN macro in debug output

 drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++-
 include/drm/drm_print.h              | 9 +++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
-- 
Jani Nikula, Intel Open Source Graphics Center

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] add new DRM_DEV_WARN macro

From: Sean Paul <sean@poorly.run>
Date: 2019-11-18 19:24:53

On Fri, Nov 15, 2019 at 01:52:53PM +0200, Jani Nikula wrote:
On Thu, 14 Nov 2019, Wambui Karuga [off-list ref] wrote:
quoted
This adds a new DRM_DEV_WARN helper macro for warnings log output that include
device pointers. It also includes the use of the DRM_DEV_WARN macro in
drm/rockchip to replace dev_warn.
I'm trying to solicit new struct drm_device based logging macros, and
starting to convert to those. [1]
This sounds good to me, I'd much prefer the non-caps versions of these
functions. So let's wait for those to bubble up and then convert rockchip to
drm_dev_*

Sean
BR,
Jani.


[1] http://patchwork.freedesktop.org/patch/msgid/63d1e72b99e9c13ee5b1b362a653ff9c21e19124.1572258936.git.jani.nikula@intel.com



quoted
Wambui Karuga (2):
  drm/print: add DRM_DEV_WARN macro
  drm/rockchip: use DRM_DEV_WARN macro in debug output

 drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++-
 include/drm/drm_print.h              | 9 +++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
-- 
Jani Nikula, Intel Open Source Graphics Center
-- 
Sean Paul, Software Engineer, Google / Chromium OS

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] add new DRM_DEV_WARN macro

From: Daniel Vetter <hidden>
Date: 2019-11-18 20:03:35

On Mon, Nov 18, 2019 at 8:24 PM Sean Paul [off-list ref] wrote:
On Fri, Nov 15, 2019 at 01:52:53PM +0200, Jani Nikula wrote:
quoted
On Thu, 14 Nov 2019, Wambui Karuga [off-list ref] wrote:
quoted
This adds a new DRM_DEV_WARN helper macro for warnings log output that include
device pointers. It also includes the use of the DRM_DEV_WARN macro in
drm/rockchip to replace dev_warn.
I'm trying to solicit new struct drm_device based logging macros, and
starting to convert to those. [1]
This sounds good to me, I'd much prefer the non-caps versions of these
functions. So let's wait for those to bubble up and then convert rockchip to
drm_dev_*
Care to ack Jani's patch directly, so this is all formal?

Jani, can you pls also add a todo.rst patch on top to adjust the
relevant item to the new color choice?

Wambui, I guess slight change of plans, it happens ...

Cheers, Daniel
Sean
quoted
BR,
Jani.


[1] http://patchwork.freedesktop.org/patch/msgid/63d1e72b99e9c13ee5b1b362a653ff9c21e19124.1572258936.git.jani.nikula@intel.com



quoted
Wambui Karuga (2):
  drm/print: add DRM_DEV_WARN macro
  drm/rockchip: use DRM_DEV_WARN macro in debug output

 drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++-
 include/drm/drm_print.h              | 9 +++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
--
Jani Nikula, Intel Open Source Graphics Center
--
Sean Paul, Software Engineer, Google / Chromium OS


-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] add new DRM_DEV_WARN macro

From: Sean Paul <sean@poorly.run>
Date: 2019-11-18 21:12:27

On Mon, Nov 18, 2019 at 09:03:20PM +0100, Daniel Vetter wrote:
On Mon, Nov 18, 2019 at 8:24 PM Sean Paul [off-list ref] wrote:
quoted
On Fri, Nov 15, 2019 at 01:52:53PM +0200, Jani Nikula wrote:
quoted
On Thu, 14 Nov 2019, Wambui Karuga [off-list ref] wrote:
quoted
This adds a new DRM_DEV_WARN helper macro for warnings log output that include
device pointers. It also includes the use of the DRM_DEV_WARN macro in
drm/rockchip to replace dev_warn.
I'm trying to solicit new struct drm_device based logging macros, and
starting to convert to those. [1]
This sounds good to me, I'd much prefer the non-caps versions of these
functions. So let's wait for those to bubble up and then convert rockchip to
drm_dev_*
Care to ack Jani's patch directly, so this is all formal?
I just time traveled to last week and acked the whole series :)

Sean
Jani, can you pls also add a todo.rst patch on top to adjust the
relevant item to the new color choice?

Wambui, I guess slight change of plans, it happens ...

Cheers, Daniel
quoted
Sean
quoted
BR,
Jani.


[1] http://patchwork.freedesktop.org/patch/msgid/63d1e72b99e9c13ee5b1b362a653ff9c21e19124.1572258936.git.jani.nikula@intel.com



quoted
Wambui Karuga (2):
  drm/print: add DRM_DEV_WARN macro
  drm/rockchip: use DRM_DEV_WARN macro in debug output

 drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++-
 include/drm/drm_print.h              | 9 +++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
--
Jani Nikula, Intel Open Source Graphics Center
--
Sean Paul, Software Engineer, Google / Chromium OS


-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
-- 
Sean Paul, Software Engineer, Google / Chromium OS

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help