iommu/exynos: Checking a device_link_add() call in exynos_iommu_add_device()
From: Markus Elfring <hidden>
Date: 2019-10-18 06:31:24
Also in:
kernel-janitors, linux-iommu, linux-samsung-soc, lkml
Hello, I tried another script for the semantic patch language out. This source code analysis approach points out that the implementation of the function “exynos_iommu_add_device” contains still an unchecked call of the function “device_link_add”. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/iommu/exynos-iommu.c?id=0e2adab6cf285c41e825b6c74a3aa61324d1132c#n1253 https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/iommu/exynos-iommu.c#L1253 How do you think about to improve it? * Which error code would you like to return for a failed device link addition at this place? * Will it be needed to delete any links as exception handling? Regards, Markus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel