[arm:cex7 15/23] drivers/net/ethernet/freescale/dpaa2/mac.c:118:6: warning: this statement may fall through

tree:   git://git.armlinux.org.uk/~rmk/linux-arm.git cex7
head:   6715e8bfb9b011b28af4b65c8180afe69a2a297c
commit: a28014964c9a164d5a6c26c4b023908fad1a6ade [15/23] dpaa2-mac: convert to phylink
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
        git checkout a28014964c9a164d5a6c26c4b023908fad1a6ade
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/freescale/dpaa2/mac.c: In function 'dpaa2_mac_validate':

quoted

drivers/net/ethernet/freescale/dpaa2/mac.c:118:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

      if (state->interface != PHY_INTERFACE_MODE_NA)
         ^
   drivers/net/ethernet/freescale/dpaa2/mac.c:121:2: note: here
     default:
     ^~~~~~~

vim +118 drivers/net/ethernet/freescale/dpaa2/mac.c

    94	
    95	static void dpaa2_mac_validate(struct phylink_config *config,
    96				       unsigned long *supported,
    97				       struct phylink_link_state *state)
    98	{
    99		__ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };
   100	
   101		/* Allow all the expected bits */
   102		phylink_set(mask, Autoneg);
   103		phylink_set_port_modes(mask);
   104		phylink_set(mask, Pause);
   105		phylink_set(mask, Asym_Pause);
   106	
   107		switch (state->interface) {
   108		case PHY_INTERFACE_MODE_NA:
   109		case PHY_INTERFACE_MODE_XAUI:
   110		case PHY_INTERFACE_MODE_10GKR:
   111			phylink_set(mask, 10000baseT_Full);
   112			phylink_set(mask, 10000baseKR_Full);
   113			phylink_set(mask, 10000baseCR_Full);
   114			phylink_set(mask, 10000baseSR_Full);
   115			phylink_set(mask, 10000baseLR_Full);
   116			phylink_set(mask, 10000baseLRM_Full);
   117			phylink_set(mask, 10000baseER_Full);
 > 118			if (state->interface != PHY_INTERFACE_MODE_NA)
   119				break;
   120	
   121		default:
   122		case PHY_INTERFACE_MODE_RGMII:
   123		case PHY_INTERFACE_MODE_SGMII:
   124			phylink_set(mask, 1000baseT_Full);
   125			phylink_set(mask, 1000baseX_Full);
   126			phylink_set(mask, 100baseT_Half);
   127			phylink_set(mask, 100baseT_Full);
   128			phylink_set(mask, 10baseT_Half);
   129			phylink_set(mask, 10baseT_Full);
   130			break;
   131		}
   132	
   133		bitmap_and(supported, supported, mask,
   134			   __ETHTOOL_LINK_MODE_MASK_NBITS);
   135		bitmap_and(state->advertising, state->advertising, mask,
   136			   __ETHTOOL_LINK_MODE_MASK_NBITS);
   137	}
   138	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation