[PATCH] arm:unwind: fix backtrace error with unwind_table
From: chenzefeng <hidden>
Date: 2019-08-06 07:32:48
Also in:
lkml, stable
Subsystem:
arm port, the rest · Maintainers:
Russell King, Linus Torvalds
For arm, when load_module success, the mod->init_layout.base would be free in function do_free_init, but do not remove it's unwind table from the unwind_tables' list. And later the above mod->init_layout.base would alloc for another module's text section, and add to the unwind_tables which cause one address can found more than two unwind table in the unwind_tables' list, therefore may get to errror unwind table to backtrace, and get an error backtrace. Signed-off-by: chenzefeng <redacted> --- arch/arm/kernel/module.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c
index deef17f..a4eb5f4 100644
--- a/arch/arm/kernel/module.c
+++ b/arch/arm/kernel/module.c@@ -403,14 +403,24 @@ int module_finalize(const Elf32_Ehdr *hdr, const Elf_Shdr *sechdrs, return 0; } -void -module_arch_cleanup(struct module *mod) -{ + #ifdef CONFIG_ARM_UNWIND +void module_arch_cleanup(struct module *mod) +{ int i; for (i = 0; i < ARM_SEC_MAX; i++) - if (mod->arch.unwind[i]) + if (mod->arch.unwind[i]) { unwind_table_del(mod->arch.unwind[i]); -#endif + mod->arch.unwind[i] = NULL; + } } + +void module_arch_freeing_init(struct module *mod) +{ + if (mod->arch.unwind[ARM_SEC_INIT]) { + unwind_table_del(mod->arch.unwind[ARM_SEC_INIT]); + mod->arch.unwind[ARM_SEC_INIT] = NULL; + } +} +#endif
--
1.8.5.6
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel