[PATCH] mmc: mxs: use devm_platform_ioremap_resource() to simplify code

Subsystems: multimedia card (mmc), secure digital (sd) and sdio subsystem, the rest

STALE2624d

3 messages, 3 authors, 2019-07-22 · open the first message on its own page

[PATCH] mmc: mxs: use devm_platform_ioremap_resource() to simplify code

From: <hidden>
Date: 2019-07-17 09:02:26

From: Anson Huang <redacted>

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.

Signed-off-by: Anson Huang <redacted>
---
 drivers/mmc/host/mxs-mmc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
index b334e81..78e7e35 100644
--- a/drivers/mmc/host/mxs-mmc.c
+++ b/drivers/mmc/host/mxs-mmc.c
@@ -571,7 +571,6 @@ static int mxs_mmc_probe(struct platform_device *pdev)
 	struct device_node *np = pdev->dev.of_node;
 	struct mxs_mmc_host *host;
 	struct mmc_host *mmc;
-	struct resource *iores;
 	int ret = 0, irq_err;
 	struct regulator *reg_vmmc;
 	struct mxs_ssp *ssp;
@@ -587,8 +586,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
 	host = mmc_priv(mmc);
 	ssp = &host->ssp;
 	ssp->dev = &pdev->dev;
-	iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	ssp->base = devm_ioremap_resource(&pdev->dev, iores);
+	ssp->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(ssp->base)) {
 		ret = PTR_ERR(ssp->base);
 		goto out_mmc_free;
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH] mmc: mxs: use devm_platform_ioremap_resource() to simplify code

From: Aisheng Dong <aisheng.dong@nxp.com>
Date: 2019-07-17 10:23:39

From: Anson.Huang@nxp.com <redacted>
Sent: Wednesday, July 17, 2019 4:53 PM

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to simplify
the code.

Signed-off-by: Anson Huang <redacted>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>

Regards
Aisheng
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mmc: mxs: use devm_platform_ioremap_resource() to simplify code

From: Ulf Hansson <hidden>
Date: 2019-07-22 13:43:48

On Wed, 17 Jul 2019 at 11:02, [off-list ref] wrote:
From: Anson Huang <redacted>

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.

Signed-off-by: Anson Huang <redacted>
Applied for next, thanks!

Kind regards
Uffe

quoted hunk
---
 drivers/mmc/host/mxs-mmc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
index b334e81..78e7e35 100644
--- a/drivers/mmc/host/mxs-mmc.c
+++ b/drivers/mmc/host/mxs-mmc.c
@@ -571,7 +571,6 @@ static int mxs_mmc_probe(struct platform_device *pdev)
        struct device_node *np = pdev->dev.of_node;
        struct mxs_mmc_host *host;
        struct mmc_host *mmc;
-       struct resource *iores;
        int ret = 0, irq_err;
        struct regulator *reg_vmmc;
        struct mxs_ssp *ssp;
@@ -587,8 +586,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
        host = mmc_priv(mmc);
        ssp = &host->ssp;
        ssp->dev = &pdev->dev;
-       iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       ssp->base = devm_ioremap_resource(&pdev->dev, iores);
+       ssp->base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(ssp->base)) {
                ret = PTR_ERR(ssp->base);
                goto out_mmc_free;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help