# \[PATCH v3 06/24\] powerpc/mm: properly set PAGE\_KERNEL flags in ioremap()

- From: Michael Ellerman \<mpe@ellerman.id.au\>
- Date: 2018-10-14 07:02:52 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2018/10/5407199
- Thread: https://ratatoskr.run/linux-arm-kernel/2018/10/5403454/t.md

```text
Michael Ellerman [ref] writes:

> Christophe Leroy [ref] writes:
>
>> Set PAGE_KERNEL directly in the caller and do not rely on a
>> hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set.
>>
>> As already done for PPC64, use pgprot_cache() helpers instead of
>> _PAGE_XXX flags in PPC32 ioremap() derived functions.
>>
>> Signed-off-by: Christophe Leroy <redacted>
>
> Something in here is breaking my p5020ds (both 32-bit and 64-bit):

Oh duh.

That's because I didn't take patch 4.

It didn't have any acks, but I guess I'll just merge it rather than
breaking things.

cheers
```